openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

Enh. Req. for ObjectPageLayout with useIconTabBar="true"

Open DerGuteWolf opened this issue 9 years ago • 9 comments

I would like to propose two enhancement for ObjectPageLayout with useIconTabBar="true":

  • I would like to have an icon as in an IconTabBar. Unfortunately an icon defined in the Button in the customAnchorBarButton is only used with useIconTabBar="false", not with useIconTabBar="true". As a bonus the count display/property like in IconTabBar would be nice.
  • When switching from ObjectPageSection to another ObjectPageSection an event should be fired.

DerGuteWolf avatar Feb 17 '16 07:02 DerGuteWolf

Hi, enhancement requests are not guaranteed to be worked on, but I forwarded them to the responsible dev team as 1680009125 to have a look. They can then say more.

Regards Andreas

akudev avatar Feb 17 '16 14:02 akudev

I just noticed that with the current beta the icon is shown, but not very nicely (too small, no space between icon and text because too small padding, the selected marker does not extend under the icon).

DerGuteWolf avatar Feb 20 '16 23:02 DerGuteWolf

I also need to display icon, text and count for each Section. Do you have any hints? I read the doku but it seems I'm missing something :(

        <sections>
            <ObjectPageSection title="AAAA" icon="sap-icon://hint">
                <subSections>
                    <ObjectPageSubSection title="">
                        <blocks>
                            <m:Text text="AAAA"/>
                        </blocks>
                    </ObjectPageSubSection>
                </subSections>
            </ObjectPageSection>

I can't figure out from Doku where to set the icon for each tab. Thanks!

gmodrogan avatar Apr 04 '16 08:04 gmodrogan

You need to use an

                <customAnchorBarButton>
                    <m:Button icon="sap-icon://hint" text="AAAA"/>
                </customAnchorBarButton>

below

<ObjectPageSection title="AAAA" icon="sap-icon://hint">

but the result is currently no very nice and far from IconTabBar...

Regards, Wolfgang

DerGuteWolf avatar Apr 04 '16 08:04 DerGuteWolf

yep, the design is not nice yet... for the moment I stick to one section(with no title) and as content I use the IconTabBar. The only drawback here is that when scrolling, the IconTabBar will not remain fixed on top. Thanks for the answer!

gmodrogan avatar Apr 04 '16 09:04 gmodrogan

Hi Wolfgang,

I verified that customAnchorBar button works the same in Tab Mode as in the standard mode (as you did as well). Apparently, you require some of the IconTabBar functionality with its rich display of icons and automatic display of digits. Since we shifted away from actually using the IconTabBar it’s not really feasible. The property name useIconTabBar mode implies that the IconTabBar is used, but this is actually not the case anymore. We are using the AnchorBar in both cases. This is why we cannot provide all of the functionality of the IconTabBar.

For the second enchantment request (the event for switching between sections), we need some context:

  • How would you use the event (for what purpose) ?
  • How do you expect it to behave ?

Thanks and Regards, Dimo

webdude21 avatar Apr 21 '16 07:04 webdude21

I would be fine with the icon in place where it is displayed currently, it could just be displayed a bit nicer with the help of some css.

For the event: I would like to make a selected tab bookmarkable, as with the icontabbar, see the various demos/tutorials.

DerGuteWolf avatar Apr 21 '16 08:04 DerGuteWolf

Hi again Wolfgang,

Will look into making the appearance of the Icon better with our designers, and I’ll get back to you on that.

About the event. There will be such event in 1.38.1. The event is called "navigate", it's fired by the ObjectPageLayout and passes as a parameter an object containing a reference to the Section that has been selected from the navigation.

Regards, Dimo

webdude21 avatar Apr 21 '16 12:04 webdude21

The open part is covered in back log item BGSOFUIPIRIN-1153.

flovogt avatar Mar 24 '22 15:03 flovogt