openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard
verified publisher icon SAP

p13n.engine with m.Table, variant name can not be changed in mobile

Open memeteminozturk opened this issue 8 months ago • 4 comments

What is the issue and how can we reproduce it?

  1. Open the sample https://sapui5.hana.ondemand.com/#/entity/sap.m.Table/sample/sap.m.sample.p13n.Engine or https://openui5nightly.hana.ondemand.com/1.134.0/#/entity/sap.m.p13n.Engine/sample/sap.m.sample.p13n.Engine
  2. Using your browser's developer tools, select and activate any mobile device emulation.
  3. Click on variants
  4. Choose the "Save As" option, enter a name, and save the new variant.
  5. Click "Manage" and modify its name
  6. Refresh page

Observed Behavior:

After refreshing the page, the updated name of the variant is not retained.

Expected Behavior:

The modified name should persist after the page refresh.

Which OpenUI5 version is your project targeting?

1.134.0, 1.134.1

Is the issue device- or browser-specific?

No response

Confirmation

  • [x] I have searched the existing issues and reviewed the relevant documentation as well as the API reference.
  • [x] I am not disclosing any internal or sensitive information.

memeteminozturk avatar Apr 11 '25 07:04 memeteminozturk

Hello @memeteminozturk ,

I didn't see any "variants" button but I clicked on the gear icon where I added a new column to the table and after refresh the column (setting) was gone.

Is this what you mean ?

Also, I believe this is expected behaviour as Demo Kit is not keeping any sample settings on refresh.

Regards, Plamen Ivanov

plamenivanov91 avatar Apr 11 '25 17:04 plamenivanov91

Hi @plamenivanov91,

Apologies for the earlier confusion. I've outlined the steps more clearly below for your reference:

  1. Open the sample https://sapui5.hana.ondemand.com/1.135.0/#/entity/sap.m.p13n.Engine/sample/sap.m.sample.p13n.Engine

  2. Enable mobile device emulation using your browser’s developer tools (e.g., select iPhone 12 Pro), then refresh the page.

  3. Click on the "Standard" variant. (Note: The label might differ depending on your browser's language settings.)

Image

  1. Click 'Save As'.

Image

  1. In the opening dialog, enter a new variant name and click 'Save'.

Image

  1. Select the newly saved variant, then click the "Manage" button.

Image

  1. Change the variant's name in the management dialog and save.

Image

  1. Refresh the page.

The variant name displayed should revert to the initial name you set, not the one you updated in the "Manage" step.

Image Before refresh

Image After refresh

If there are still any misunderstandings or if something remains unclear, I’d be happy to assist further.

memeteminozturk avatar Apr 21 '25 13:04 memeteminozturk

Hello @memeteminozturk ,

Thank you for your pull request. I've created an internal record DINC0499992. The status of the issue will be updated here in GitHub.

Regards, Martin

MapTo0 avatar May 12 '25 10:05 MapTo0

According to git bisect, the issue is happening since https://github.com/SAP/openui5/commit/1fe819ae47fcb02fbf9f730a662cbe29b86939a3. The order of the focus handling seems to have changed in mobile.

boghyon avatar May 21 '25 15:05 boghyon

Hi @memeteminozturk,

The fix will be available in version 1.139 of SAPUI5 which will be released in CW 37.

Best Regards, Gery

gerym avatar Jul 04 '25 09:07 gerym