openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

[ui5-OverflowToolbar]: focus outline is clipped

Open MahendraSai024 opened this issue 1 year ago • 1 comments

OpenUI5 version: latest

Browser/version (+device/version): firefox, Mac

Any other tested browsers/devices(OK/FAIL): chrome, edge(Fail)

Bug Description When selected/clicked on the currentLocationText of the Breadcrumbs. The Focus is not on all sides of the UI.

Visible in the Sample: https://sdk.openui5.org/entity/sap.m.Table/sample/sap.m.sample.TableBreadcrumb In Page.view.xml, Ln14, replace it with Breadcrumbs id="breadcrumb" currentLocationText="Document" (currentLocationText="Document" is added to the Breadcrumbs) image image

The above image shows that the boundary/focus outline is clipped. The issue doesn't occur when Breadcrumbs is used with Toolbar. Instead, it happens when using the OverflowToolbar.

Affected Component ui5-breadcrumbs

Steps to reproduce the problem:

  1. Go to the sample application: https://sdk.openui5.org/entity/sap.m.Table/sample/sap.m.sample.TableBreadcrumb
  2. Open the Page.view.xml file and change the Line 14 by < Breadcrumbs id="breadcrumb" currentLocationText="Click Here" />
  3. Just added currentLocationText to the
  4. Click on the "Click Here" located at the header section of the table in the application UI which is running in parallel
  5. The Focus is not adequately visible on all sides

Expected Behaviour The focus outline must be adequately visible on all sides, as shown in the image below. image image When replacing the OverflowToolbar with the Toolbar, it works as expected.

Observed behaviour image

For more information check the video attached below:

https://github.com/user-attachments/assets/7eeb33b0-a57d-45dc-b278-85ab1abc438f

MahendraSai024 avatar Oct 21 '24 07:10 MahendraSai024

Hi @MahendraSai024,

I've created the internal incident DINC0305045 for your issue. We'll have a look and contact you once we find a solution.

DonkeyCo avatar Oct 21 '24 14:10 DonkeyCo

The fix https://github.com/SAP/openui5/commit/521b2b01e04e8013ce9893490f322b0e10d3d53c is planned to be available with the release of 1.131.

50gY avatar Oct 30 '24 08:10 50gY