openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

showClearIcon on MultiComboBox does not work

Open niechenghai opened this issue 1 year ago • 5 comments

OpenUI5 version: 1.124.0 Browser/version (+device/version): Chrome Version 120.0.6099.71 (Official Build) (x86_64) Any other tested browsers/devices(OK/FAIL): Edge URL (minimal example if possible): https://ui5.sap.com/#/entity/sap.m.MultiComboBox/sample/sap.m.sample.MultiComboBoxClearIcon/code User/password (if required and possible - do not post any confidential information here):

Steps to reproduce the problem:

  1. Open https://ui5.sap.com/#/entity/sap.m.MultiComboBox/sample/sap.m.sample.MultiComboBoxClearIcon/code
  2. Select some items
  3. There is no clear icon showing

What is the expected result? There should be a clear icon which can clear all selection What happens instead? No icon showing Any other information? (attach screenshot if possible)

niechenghai avatar Jun 26 '24 03:06 niechenghai

Thanks a lot @niechenghai for reporting this issue. I have created an internal incident DINC0194245 and the respective team will update the status of the issue here in GitHub.

flovogt avatar Jun 27 '24 06:06 flovogt

Hello @niechenghai

The clear icon is designed to clear the text, not the tokenized items. Check Fiori Guidelines: https://experience.sap.com/fiori-design-web/multi-combobox/#clear

Best Regards, Martin

MapTo0 avatar Jun 27 '24 07:06 MapTo0

Allowing to clear all tokens seems to be a commonly expected feature:

  • https://github.com/SAP/openui5/issues/3481

    As a user I don't see how much items and which have I really selected. I expecting for the Clear button to clear all. In the other case I will just delete with backspace.

  • https://github.com/SAP/openui5/issues/3729

    Adding an overal 'clear' icon to a MultiComboBox (or MultiInput) makes a lot of sense IMO (I would opt for a verbal 'clear' left to the arrow or search help icon).

  • https://github.com/SAP/openui5/issues/4078 (this issue)

Could you consider reopening this issue and processing it as an enhancement request? @MapTo0 @hristop @ndeshev

boghyon avatar Jul 02 '24 11:07 boghyon

Hello @boghyon, we will create a feature request, as such it should go through the Inner Source process and approved and specified by the Core design team.

ndeshev avatar Jul 03 '24 08:07 ndeshev

This is an update to let you know that the topic is currently being researched by the UX team and the result will be determined via FIORIDESIGN-12575.

hristop avatar Aug 02 '24 05:08 hristop