openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

JS Doc for calculateStartDate in SinglePlanningCalendarView

Open signix opened this issue 1 year ago • 1 comments

OpenUI5 version:

The jsdoc of method calculateStartDate in file src/sap.m/src/sap/m/SinglePlanningCalendarView.js does not indicate a return type. Should it include * @return {object} the startDate of the view as we can see in the implementations (SinglePlanningCalendarWorkWeekView, SinglePlanningCalendarWorkWeekView or SinglePlanningCalendarMonthView) ?

Without this the typescript function is expected to return void.

I can add a PR if this is the case.

Thank you

signix avatar May 07 '24 16:05 signix

I've opened an internal incident (DINC0144944) for this problem. The colleagues will have a look and will get back to you

DonkeyCo avatar May 08 '24 06:05 DonkeyCo

Hey @signix,

Thanks for sharing your finding, the issue was fixed with the commit linked above and will be available in UI5 version 1.125.

Best, Diana

didip1000 avatar May 22 '24 11:05 didip1000

Thank you for the fix

signix avatar May 22 '24 12:05 signix