openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

Published 20 hours ago • verified publisher icon SAP

sap.ui.layout.form.SimpleForm Aggregation Clone Issue

Open edemuck4timbuktu opened this issue 11 months ago • 4 comments

OpenUI5 version: 1.120.11 Browser/version (+device/version): Chrome Version 122.0.6261.131 (Offizieller Build) (64-Bit) URL (minimal example if possible): https://plnkr.co/plunk/uyRhWUvienyHvQ1p

Steps to reproduce the problem:

  1. Start the plnkr Demo App

What is the expected result? The sap.m.OverflowToolbar of each sap.ui.layout.form.SimpleForm should be displayed. Only the last sap.ui.layout.form.SimpleForm displayed the toolbar.

What happens instead? The sap.m.OverflowToolbar of the sap.ui.layout.form.SimpleForm, which is the content of a sap.f. Card, isn't displayed.

Any other information? (attach screenshot if possible) First analysis: The cloning of the sap.ui.layout.form.SimpleForm triggers by rendering of the aggregation pages of the sap.m.Carousel isn't working properly. After cloning the SimpleForm, the aggregation toolbar isn't part of the new SimpleForm. See https://github.com/SAP/openui5/blob/1.120.11/src/sap.ui.layout/src/sap/ui/layout/form/SimpleForm.js#L1141

edemuck4timbuktu avatar Mar 25 '24 15:03 edemuck4timbuktu

Thanks for reporting this issue. In UI5 hidden aggregations are not part of clones. The SimpleForm uses the form as a hidden aggregation and this seems like the main issue here. Internal incident DINC0107232 is created for this github issue.

aborjinik avatar Mar 27 '24 16:03 aborjinik

Hi,

this issue is already solved with SAPUI5 version 1.121

UserAbcd1234 avatar Jun 04 '24 10:06 UserAbcd1234

Fixed with https://github.com/SAP/openui5/commit/a8a81993b1782b8d47dbafa355f262f7b818ac35

flovogt avatar Jun 07 '24 06:06 flovogt

@flovogt Thank you ;) Why is this fix not in the long-term maintenance version 1.120 ? image

edemuck4timbuktu avatar Jun 28 '24 11:06 edemuck4timbuktu

Hello @edemuck4timbuktu, Thank you for sharing this finding. I've created an internal incident DINC0203677 reagrding your downport request. The status of the issue will be updated here in GitHub. Regards, Gergana

GerganaKremenska avatar Jul 08 '24 08:07 GerganaKremenska

@edemuck4timbuktu : Could you please tell us what SAP product has an problem? We have strict downport guidelines to keep running installations stable. Only if there is a real issue with a real application a downpord to older SAPUI5 versions is done.

UserAbcd1234 avatar Jul 15 '24 07:07 UserAbcd1234

@UserAbcd1234 It is ok, thanks. I will be wait to the next Long-term Maintenance version.

edemuck4timbuktu avatar Jul 23 '24 06:07 edemuck4timbuktu

Hello @edemuck4timbuktu,

Thank you for your response!

Given all the communication, I think it is appropriate to mark the ticket as resolved.

Best regards, Konstantin Gogov SAPUI5 GitHub Dispatcher

kgogov avatar Jul 23 '24 09:07 kgogov