openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

Correct padding for ObjectPageLayout showing title in header content on display class Desktop-XL

Open patrickhuy opened this issue 1 year ago • 4 comments

When ObjectPageLayout is set to showTitleInHeaderContent and the header is displayed with on a screen of class Desktop-XL the content area (and especially noticeable: the image) don't have a top padding.

This can be observed here: https://jsfiddle.net/395hrpye/ (the padding from the icon to top goes away when entering the Desktop-XL layout)

https://github.com/SAP/openui5/assets/66731536/1f0dd13d-586b-4223-bcfa-3f4011c96f9a

This PR applies the padding from Tablet and Desktop also for Desktop-XL in both the theme "horizon" as well as "quartz".

patrickhuy avatar Jan 30 '24 14:01 patrickhuy

Hi @patrickhuy, Thank you for sharing your enhancement proposal. I've created an internal incident DINC0053713. The responsible team will have handle this PR and post further updates here.

flovogt avatar Jan 31 '24 07:01 flovogt

Hi @flovogt, there's already DINC0053067 for the same issue. Shall we close DINC0053713 as a duplicate?

codeworrior avatar Jan 31 '24 07:01 codeworrior

Duplicate DINC0053713 is closed. Thanks for pointing this out @codeworrior

flovogt avatar Jan 31 '24 07:01 flovogt