openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

Feature request: access to the IllustratedMessage as noData in the UploadSet

Open jvanattedev opened this issue 1 year ago • 4 comments

Currently, it is very difficult to access the IllustrateMessage as noData aggregation in the UploadSet. In 1.119 only following properties are available:

  • noDataDescription
  • noDataIllustrationType
  • noDataText

Developers need to be able to change the size, illustration etc. of the IllustratedMessage inside. I have found a workaround but that is certainly not ideal: let oList = this.byId("uploadSet").getDependents()[0]; let oIllustratedMessage = new IllustratedMessage({ illustrationSize: IllustratedMessageSize.Dot, illustrationType: IllustratedMessageType.NoMail, title: 'No Data' }); oList.setAggregation("noData", oIllustratedMessage);

The UI5 API should make this straightforward, also for at least version 1.108 which is Long-term Maintenance, Q4/2027.

jvanattedev avatar Oct 27 '23 09:10 jvanattedev

Hello @jvanattedev,

Thank you for sharing your enhancement proposal. I've created an internal incident 2370131395. The status of the issue will be updated here in GitHub.

Regards, Niya

niyap avatar Oct 27 '23 11:10 niyap

Hello @jvanattedev,

Thank you for reaching out for the Feature Request on the UploadSet, Currently we are discussing with our Architect / PO a better way to handle this use case. We have created a Backlog item for the same: FIORITECHP1-28989

Currently as you have mentioned dUploadSet does provide properties such as :

  1. noDataText maps to -> sap.m.IllustratedMessage.Title
  2. noDataDescription maps to -> sap.m.IllustratedMessage.Description
  3. noDataIllustrationType maps to -> sap.m.IllustratedMessage.illustrationType

Which can be used to update certain properties of IllustratedMessage. Access to sap.m.IllustratedMessage.illustrationSize has yet not been provided. Currently untill the backlog is completed the mentioned workaround can still be used.

However as you have mentioned you would require the changes for 1.108, Performing the downport to 1.108 would not be possible as this would be a new enhancement on the UploadSet Control. Adding of a new API / Properties / Aggregation would be considered an enhancements and as per guidelines they would not be down ported to Long Term Releases.

Thanks, Ashwin

AshwinKumarBolar avatar Nov 06 '23 09:11 AshwinKumarBolar

This issue will be covered in backlog item FIORITECHP1-28989.

flovogt avatar Nov 15 '23 14:11 flovogt

Hello @jvanattedev,

Thank you for reaching out for the Feature Request on the UploadSet, Currently we are discussing with our Architect / PO a better way to handle this use case. We have created a Backlog item for the same: FIORITECHP1-28989

Currently as you have mentioned dUploadSet does provide properties such as :

  1. noDataText maps to -> sap.m.IllustratedMessage.Title
  2. noDataDescription maps to -> sap.m.IllustratedMessage.Description
  3. noDataIllustrationType maps to -> sap.m.IllustratedMessage.illustrationType

Which can be used to update certain properties of IllustratedMessage. Access to sap.m.IllustratedMessage.illustrationSize has yet not been provided. Currently untill the backlog is completed the mentioned workaround can still be used.

However as you have mentioned you would require the changes for 1.108, Performing the downport to 1.108 would not be possible as this would be a new enhancement on the UploadSet Control. Adding of a new API / Properties / Aggregation would be considered an enhancements and as per guidelines they would not be down ported to Long Term Releases.

Thanks, Ashwin

Just to add some information. On initial load, the workaround is ok. But when you add an attachment, and then remove it again (so the list is empty). The original size is showing again. We can reset the size again in AfterItemRemoved using a timeout(0), but then you can see the large drawing first very shortly, followed by the size you have (re)set. It results in a flickering effect. BeforeItemRemoved is too soon.

jvanattedev avatar Nov 15 '23 14:11 jvanattedev