openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

AnalyticalBinding/AnalyticalTable: Missing section/lines in subtree after paging

Open nils opened this issue 2 years ago • 2 comments

OpenUI5 version: 1.96.9

Browser/version (+device/version): Version 103.0.5060.134 (Official Build) (32-bit) (Windows 10)

Any other tested browsers/devices(OK/FAIL): -/-

URL (minimal example if possible): Not possible, unfortunately 🙁 I can make a very-non-minimal example available internally.

User/password (if required and possible - do not post any confidential information here): Not possible, can be made available internally.

Steps to reproduce the problem:

  1. have an AnalyticalTable with numberOfExpandedLevels > 0, autoExpandMode = Bundled
  2. have enough data for pagination to be required
  3. scroll down in table to load additional lines

What is the expected result? image

What happens instead? image

Any other information? (attach screenshot if possible) I traced the issue down, the issue was caused by empty array entries in this.mKeyIndex for the parent node (groupID "/GB/RG-2/"). This is caused by the iStartIndex being >0. image

So, I could work around the issue by monkey patching this additional line oGroupMembersRequestDetails.iStartIndex = 0; into this: https://github.com/SAP/openui5/blob/445e7a4029d1886b66981ec6a2f19206c102f143/src/sap.ui.core/src/sap/ui/model/analytics/AnalyticalBinding.js#L3383-L3384

With my limited understanding, this would make sense looking at the similar case a few lines later, doing the same thing: https://github.com/SAP/openui5/blob/445e7a4029d1886b66981ec6a2f19206c102f143/src/sap.ui.core/src/sap/ui/model/analytics/AnalyticalBinding.js#L3385-L3392

@ThomasChadzelek I see you did change these lines of code last time (git blamed, but not blaming you 😏): https://github.com/SAP/openui5/commit/05a8e9ff5d368ab7ffa24af40deb59a6254ad789 https://github.com/SAP/openui5/commit/6b20872b42a64e23eb424b678cb33fc1480be4cd

If you could help me validate if my workaround is actually a valid solution, that would be a huge help!

nils avatar Aug 04 '22 07:08 nils

@ThomasChadzelek moved on to other topics, so support from another source would be required 🙂

nils avatar Aug 04 '22 13:08 nils

Hello @nils

In order to process this issue to the responsible team I would need some more information or example so I can debug and forward to responsible team (Core team or Tables team or other?). Could you please assist?

Regards, Martin (Github Dispatcher)

MapTo0 avatar Aug 05 '22 08:08 MapTo0

Hi @MapTo0,

I have created an internal incident (2280169612) for the UI5 models team.

This minimal example shows the issue: https://analytics-issue.cfapps.sap.hana.ondemand.com/analyticaltable/webapp/index.html

I will give an update here when the issue is resolved, in case anyone outside SAP encounters the issue as well.

nils avatar Aug 24 '22 14:08 nils

Hi @nils,

Thanks for the findings, the proposed fix and the example. I am just preparing a fix for this issue.

Best Regards, Sven

SvBe avatar Sep 14 '22 09:09 SvBe

The fix is submitted and will be part of 1.107.

SvBe avatar Sep 19 '22 07:09 SvBe

Fixed by https://github.com/SAP/openui5/commit/3f3b2dc1ef17cbdb7189cdda76949656a53ed8ab

flovogt avatar Sep 22 '22 08:09 flovogt