openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

Published 20 hours ago • verified publisher icon SAP

Replace jQuery $().toggleClass by vanilla js classList.toggle in sap.ui.unified library

Open mauriciolauffer opened this issue 3 years ago • 3 comments

Just replacing jQuery .toggleClass by vanilla js classList.toggle in sap.ui.unified library. Hopefully more people can help tackling other libraries, then other jQuery features, until we don't have jQuery in the code base anymore.

jQuery .toggleClass can be replaced by classList.toggle and it's supported by IE11, not just modern browsers.

mauriciolauffer avatar Jan 31 '22 23:01 mauriciolauffer

sap.f - https://github.com/SAP/openui5/pull/3442 sap.tnt - https://github.com/SAP/openui5/pull/3446

mauriciolauffer avatar Jan 31 '22 23:01 mauriciolauffer

Hello @mauriciolauffer , Thank you for your pull request. I've created an internal record 2280047628. The status of the issue will be updated here in GitHub. Regards, Diana

Shtilianova avatar Feb 04 '22 10:02 Shtilianova

CLA assistant check
All committers have signed the CLA.

cla-assistant[bot] avatar Feb 06 '22 04:02 cla-assistant[bot]