openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

Create manifest models async (/sap.app/dataSources and /sap.ui5/models)

Open mauriciolauffer opened this issue 3 years ago • 1 comments

OpenUI5 version: ALL

Browser/version (+device/version): ALL

URL (minimal example if possible): https://github.com/SAP/openui5-masterdetail-app/blob/master/webapp/manifest.json

What is the expected result? Models declared in the manifest.json (/sap.app/dataSources and /sap.ui5/models) should be loaded async.

https://github.com/SAP/openui5/blob/fbdcd8b7714466663b34a443d41245b8c207ec6c/src/sap.ui.core/src/sap/ui/core/Component.js#L1736

What happens instead? Method sap.ui.core.Component._createManifestModels creates everything sync with sap.ui.requireSync

https://github.com/SAP/openui5/blob/fbdcd8b7714466663b34a443d41245b8c207ec6c/src/sap.ui.core/src/sap/ui/core/Component.js#L1744

mauriciolauffer avatar Mar 11 '21 05:03 mauriciolauffer

This enhancement is already on our roadmap (under the internal ID CPOUI5FRAMEWORK-210).

codeworrior avatar Mar 11 '21 06:03 codeworrior

Same as https://github.com/SAP/openui5/issues/3134, model classes are now asynchronously required if the Component creation is async as well. Since https://github.com/SAP/openui5/commit/337b1768cff287cf22c3fbfe4458afd66795c894.

boghyon avatar Dec 08 '23 17:12 boghyon