openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

v2.ODataTreeBinding doesn't respect `suspended` state

Open boghyon opened this issue 4 years ago • 6 comments

URL (minimal example if possible)

https://embed.plnkr.co/xu4Q4DgR9yO559Sp?show=view/Root.view.xml,preview:?sap-ui-xx-componentPreload=off

Given:

<Tree xmlns="sap.m" items="{
  path: '/OrderNodeSet',
  suspended: true,
  ...
}">

What is the expected result?

Like ODataListBinding, ODataTreeBinding respects suspended: true from the binding constructor and sends no request until oODataTreeBinding.resume() is called.

What happens instead?

Regardless of the suspended: true, the ODataTreeBinding sends a request right away, unlike ODataListBinding.

boghyon avatar Feb 17 '21 12:02 boghyon

Hello @boghyon , Thank you for sharing this finding. I've created an internal incident 2180121759. The status of the issue will be updated here in GitHub. Regards, Oliver

stoyanovski avatar Feb 22 '21 10:02 stoyanovski

Totally forgot that there is also ClientTreeBinding which doesn't seem to handle suspended: true either, according to the source code.

boghyon avatar Feb 23 '21 16:02 boghyon

Hi @boghyon ,

I have created a requirement for supporting suspend and resume for the sap.ui.model.odata.v2.ODataTreeBinding. It is tracked as FIORITECHP1-19728 internally. Unfortunately, the responsible team will not be able to work on this request in the coming months.

What is the expected behavior for the ClientTreeBinding when it is suspended?

Best regards Mathias.

uhlmannm avatar Feb 24 '21 10:02 uhlmannm

Thank you for the update.

What is the expected behavior for the ClientTreeBinding when it is suspended?

Not necessarily for ClientTreeBinding, but generally, suspended binding should prevent DOM update and firing related events in case they're not needed.

boghyon avatar Feb 24 '21 13:02 boghyon

is there any update on this issue and if it is planned to be resolved? @uhlmannm

wwrigley1 avatar May 19 '23 06:05 wwrigley1

@wwrigley No, there is unfortunately no update.

Best regards Mathias.

uhlmannm avatar May 19 '23 07:05 uhlmannm