openui5 icon indicating copy to clipboard operation
openui5 copied to clipboard

sap.m.SelectDialog: Allow clear in single selection mode

Open zypA13510 opened this issue 5 years ago • 6 comments

The clear button will always be enabled, if showClearButton=true and multiSelect=false. The clear button behavior is redefined to act as clear+confirm in single selection mode.

This closes #2379. This will provide a workaround for #898.

P.S. I'm not sure if this should count as a [FIX] or a [FEATURE], so it's not included in any title.

zypA13510 avatar Jan 17 '19 06:01 zypA13510

Hi @zypA13510,

Thank you for your contribution. I created internal incident regarding your pull-request. The colleagues from the corresponding team will check if it's relevant for their control.

Best Regards, Oliver

stoyanovski avatar Jan 28 '19 16:01 stoyanovski

Hello @zypA13510 ,

As is described in your related incident: https://github.com/SAP/openui5/issues/2379 We will analyze and evaluate all possible interactions and then we will make the decision.

Thank you for your contribution. Your proposal(pull request) will be evaluated as well. We will keep you in touch regarding the progress and our final decision. For this reason, we are currently not able to approve your pull request.

Thanks again for your proactivity and contribution!

Regards, Niya

niyap avatar Jan 30 '19 11:01 niyap

Actually, this was submitted prior to the reply in 2379 (but probably not being tracked for some reasons?)

zypA13510 avatar Jan 31 '19 07:01 zypA13510

Internal record is 1980259563. The status of the issue will be updated here in GitHub.

Shtilianova avatar May 13 '19 06:05 Shtilianova

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 05 '20 11:08 CLAassistant

This PR will be covered in backlog item FIORIDESIGN-614

flovogt avatar Jun 15 '23 15:06 flovogt