Many controls interrupt browser navigation with keyboard when focused

[boghyon]

Related to this issue with sap.m.Slider, I noticed there are several more controls interrupting global keyboard handling when they are focused:

• [x] sap.m.(Range)Slider --> Fixed by https://github.com/SAP/openui5/commit/4a6bfc5f8138fc8d76e43ae2dda99db279547d73
• [x] sap.m.BusyIndicator --> Will be covered in backlog item CPOUI5FRAMEWORK-174
• [x] sap.m.IconTabBar --> Fixed by https://github.com/SAP/openui5/commit/a71d0e8706fbb65375fd85503b8f835a98ce62f5
• [x] sap.tnt.SideNavigation --> Fixed by https://github.com/SAP/openui5/commit/a71d0e8706fbb65375fd85503b8f835a98ce62f5
• [x] sap.m.ListBase --> Fixed by https://github.com/SAP/openui5/commit/939cd59f205d04d4466e8163261b231fee60416f
• [x] sap.m.Breadbrumbs --> Fixed by https://github.com/SAP/openui5/commit/cd4846b30947928685bdb85f17f1ad858f6c5391
• [x] sap.m.TabContainer --> Fixed by https://github.com/SAP/openui5/commit/1a63acd2ed4855a132a697b50d449ce8fe49a909
• [x] sap.m.ActionSheet --> Fixed by https://github.com/SAP/openui5/commit/691475300c7d7bf7adaca5451d1081e97e609683 and https://github.com/SAP/openui5/commit/42ae4a7d0c8e7f3a09a15b3b24f60aff25fefe43
• [x] sap.m.SegmentedButton --> Fixed by https://github.com/SAP/openui5/commit/1a63acd2ed4855a132a697b50d449ce8fe49a909
• [x] sap.m.WizardProgressNavigator --> Fixed by https://github.com/SAP/openui5/commit/999cf88de3d9180f5adecae7d314dbd22d283e07
• [x] sap.m.RadioButtonGroup --> Fixed by https://github.com/SAP/openui5/commit/a71d0e8706fbb65375fd85503b8f835a98ce62f5
• [x] sap.m.SelectList --> Fixed by https://github.com/SAP/openui5/commit/f1c8b1e161a4f710d88de82dcadd6d412cb5dfcd
• [ ] sap.m.HeaderContainer
• [x] sap.m.ColorPalette --> Fixed by https://github.com/SAP/openui5/commit/1a63acd2ed4855a132a697b50d449ce8fe49a909
• [x] sap.m.FacetFilter --> Fixed by https://github.com/SAP/openui5/commit/1a63acd2ed4855a132a697b50d449ce8fe49a909
• [x] sap.m.MaskInput --> Works as expected
• [x] sap.m.SinglePlanningCalendarGrid --> Fixed by https://github.com/SAP/openui5/commit/f321fb921cfc72576a64e8380f9f9851e4d8d566
• [x] sap.ui.unified.Menu --> Fixed by https://github.com/SAP/openui5/commit/1a63acd2ed4855a132a697b50d449ce8fe49a909
• [x] sap.m.MultiInput/.MultiComboBox --> Fixed by https://github.com/SAP/openui5/commit/ff3da57fc5d9306ea67b1e418380bf0e41ceff35
• [x] sap.m.TimePicker with maskMode enabled --> Works as expected

Browsers allow page navigation with the following keyboard shortcuts:

• Windows & Chrome OS / Linux:
  • Left Alt + ←→
  • Right Alt (Alt Gr) + ←→
• macOS:
  • ⌘ + ←→
  • ⌘ + []

^{Other global shortcuts: https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts}

It would be nice if controls, which support keyboard handling, could respect shortcuts of the user agent if applicable.

[aborjinik]

Thanks your research and feedback. I have created 8 internal tickets per control issue. So we will track over 1770135328,1770135326, 1770135325, 1770135324, 1770135323, 1770135321, 1770135288

[a-z-ivanov]

The issue is fixed for sap.m.TabContainer and sap.m.SegmentedButton. c4719ec63ad7a2e8a859c8bb58d7ef516c137fad fcf68f3dc64f34c527615e1bd2619d447d6447e0

[radostinaTs]

The issue is fixed for sap.m.ActionSheet and sap.m.WizardProgressNavigator. https://github.com/SAP/openui5/commit/470652bffc00917c0aa10710762be2c566d8bc07 https://github.com/SAP/openui5/commit/67d9c50e50dd2030c5fb5cd10c27204d97a1322b

[SvetoslavSpasov]

The issue is also fixed for sap.m.RadioButtonGroup, sap.m.IconTabHeader used by the IconTabBar and sap.tnt.NavigationList used by the sap.tnt.SideNavigation. a71d0e8706fbb65375fd85503b8f835a98ce62f5

[myordanov]

sap.m.Breadcrumbs fixed

[boghyon]

Seems to be fixed for all controls that I know. Thank you everyone for fixing the issue. @myordanov @SvetoslavSpasov @radostina-tsiklovska @a-z-ivanov

[boghyon]

@matz3 @aborjinik sap.m.SelectList seems to have the same issue: https://openui5nightly.hana.ondemand.com/#/entity/sap.m.SelectList

1. Select one preview
2. Click on one of the items
3. Try to nav back to previous page by Alt + left arrow

[boghyon]

Added more controls that have the issue. Would be nice if this issue could be reopened.

[boghyon]

Is/Was there an internal discussion on how to tackle this issue* more.. efficiently or centrally? I can create PRs to fix all those controls one by one but using setDisabledModifiers in each control manually doesn't seem to be a future-proof solution since I'm not taking closed-sourced or any new controls into account.

---

[*]: Generally having conflicts with global keyboard shortcuts from UA.

[flovogt]

Internal Tickets created:

• [x] sap.m.Breadcrumbs: 2270066817
• [x] sap.m.BusyIndicator: 2270042441
• [x] sap.m.TabContainer: 2270042442
• [x] sap.m.ActionSheet: 2270042443
• [x] sap.m.SegmentedButton: 2270042447
• [x] sap.m.WizardProgressNavigator: 2270042448
• [x] sap.m.HeaderContainer: 2270042449
• [x] sap.m.ColorPalette: 2270042461
• [x] sap.m.FacetFilter: 2270042468
• [x] sap.m.MaskInput: 2270042469
• [x] sap.ui.unified.Menu: 2270042470
• [x] sap.m.MultiInput/.MultiComboBox: 2270042491
• [x] sap.m.TimePicker: 2270042492

[boghyon]

Btw: just noticed the Right Alt (Alt Gr) is not considered in the fixes so far. But I guess most users use the Left Alt when navigating with the keyboard.

[terezamch]

Hello, @boghyon ,

The TimePicker input and the MaskInput work as expected - only meta key + [ or ] should navigate backward/forward. They behave like the native input tag. In the picker part of the TimePicker there is no issue with the keyboard shortcuts.

Therefore I am marking these two as done.

Best regards, Tereza

[terezamch]

Hello again @boghyon ,

The SegmentedButton, ColorPalette, FacetFilter, Menu and TabContainer are fixed now. Therefore I am marking them as done.

Best regards, Tereza

[MapTo0]

MultiComboBox and MultiInput

Thanks for reporting! Martin

[nnaydenow]

Hi @boghyon,

sap.m.Link is used as child element in sap.m.Breadcrumbs. sap.m.Link already provide this functionality and we can mark sap.m.Breadcrumbs as fixed. I tested it on macOS so it seems to work correctly.

Edit: My mistake. Tested irrelevant behaviour. I'm going to process the issue

Update: sap.m.Breadcrumbs issue is fixed cd4846b30947928685bdb85f17f1ad858f6c5391

Regards, Nayden

[NLeenaRaj]

Hi @boghyon, Good day!!

The issue is fixed for sap.m.HeaderContainer control https://github.com/SAP/openui5/commit/bd8d9f1d295e99162fba36133e63a14597d1911e

Thanks & Regards, Leena Raj N

[flovogt]

All mentioned controls are covered. Thanks @boghyon for opening this issue.

[flovogt]

BusyIndicator will be handled in the mentioned backlog item CPOUI5FRAMEWORK-174. fyi @ecker