open-ux-tools icon indicating copy to clipboard operation
open-ux-tools copied to clipboard

TBI - Align all defintions of Odata Version

Open IainSAP opened this issue 1 month ago • 0 comments

Description (include screenshots)

Currently there are multiple definitions (enums and types) for odata version. This means the same types cannot be used across module interfaces. For example, @sap-ux/odata-service-inquirer and @sap-ux/fiori-elements-writer use the odata version defintion from @sap-ux/odata-service-writer but @sap-ux/axios-extension is using its own definition. This means some conversion is required.

This TBI should update all to the same type: https://github.com/SAP/ui5-manifest/blob/0bccebd694a12ee931cfc342b32cbf4693aa785d/types/manifest.d.ts#L985

However this type allows undefined which we should not allow so :

NonNullable<ManifestNamespace.Setting['odataVersion']>;

Also many consumers expect and use enum value iteration in definitions of other types, so this may not be suitable without some minor refactoring.

Value

Optional - details on how this technical backlog item provides value to end-users or dev team eg. Performance, Quality, Maintainability. This will help determine the ranking in relation to feature development

Architecture Elaboration

Does it requires architecture elaboration?

Notes

Tasks

  • [ ] Task 1

IainSAP avatar May 09 '24 17:05 IainSAP