luigi icon indicating copy to clipboard operation
luigi copied to clipboard

Update dependencies

Open JohannesDoberer opened this issue 3 years ago • 5 comments

Update dependencides in root, core, client, client-frameworks-support, plugins update webpack to the latest 4.X version

e2e-test-application

  • migrate to webpack 5
  • newest angular

JohannesDoberer avatar Feb 23 '22 13:02 JohannesDoberer

Is this on the roadmap yet?

I would like to know when we can expect support for Angular Ivy.

JenniferStamm avatar Jun 23 '22 12:06 JenniferStamm

Hi @JenniferStamm, The issue is currently in the backlog. Most of the updates here are related to internal dependencies on our side. We haven't specifically considered Angular Ivy yet in the details. Could you let us know how this affects you and what are you trying to achieve or which of our packages would affect you ? Two of our auxiliary packages, 1 and 2 are Angular-based, that I believe would be the ones that we would need to consider.

ndricimrr avatar Jun 24 '22 10:06 ndricimrr

Thanks @ndricimrr.

When compiling our application with ngc we run into the following issue:

[0] ../../node_modules/@luigi-project/client-support-angular/lib/luigi.angular.support.module.d.ts:5:22 - error NG6002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class.
[0] 
[0] This likely means that the library (@luigi-project/client-support-angular) which declares LuigiAngularSupportModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

Currently, this is not blocking my team for two reasons:

  1. We only use ngc when extracting strings for localization.
  2. At the moment, with Angular 13, we can still work around it by configuring ngcc with the following properties: ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points

JenniferStamm avatar Jun 24 '22 11:06 JenniferStamm

Also, are you aware that the security support for Angular 11 ended last month? [0, 1]

I will have to check with the compliance and security expert in my team, but this might also impact us.

[0] https://angular.io/guide/releases#support-policy-and-schedule [1] https://endoflife.date/angular

JenniferStamm avatar Jun 24 '22 12:06 JenniferStamm

Hello Jennifer, created an issue for that. Best regards,

Johannes

JohannesDoberer avatar Jun 28 '22 12:06 JohannesDoberer