fundamental-styles icon indicating copy to clipboard operation
fundamental-styles copied to clipboard

fix(styles): redesign line/link Tiles in both static and edit mode

Open alexhristov14 opened this issue 1 year ago • 5 comments

Related Issue

related to https://github.com/SAP/fundamental-ngx/issues/11490

Description

Design changes to the generic line tiles according to the specs

Screenshots

Before:

Screenshot 2024-10-03 at 9 08 49 AM

After:

Screenshot 2024-10-03 at 9 09 23 AM

alexhristov14 avatar Oct 03 '24 13:10 alexhristov14

Deploy Preview for fundamental-styles ready!

Name Link
Latest commit 6c3b948e5150a242ec10ea8a0b21ef7893319285
Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/67f5d577fc0f9100080273bf
Deploy Preview https://deploy-preview-5676--fundamental-styles.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 03 '24 13:10 netlify[bot]

Screenshot 2024-10-03 at 11 48 47 AM

The focus outline radius doesn't have the same radius as the Tile

InnaAtanasova avatar Oct 03 '24 15:10 InnaAtanasova

Screenshot 2024-10-03 at 11 50 50 AM

Active state: there should be 1 outline.

InnaAtanasova avatar Oct 03 '24 15:10 InnaAtanasova

https://github.com/user-attachments/assets/f4c9c611-7275-4450-b630-382e219c02f1

there's a "jump" on hover. Probably somewhere you set/remove a border that causes change of element height.

InnaAtanasova avatar Oct 03 '24 15:10 InnaAtanasova

Screenshot 2024-10-03 at 11 55 59 AM Please fix the lint errors

InnaAtanasova avatar Oct 03 '24 15:10 InnaAtanasova

@InnaAtanasova can you check?

droshev avatar Nov 20 '24 14:11 droshev

Screen.Recording.2024-10-03.at.11.51.54.AM.mov there's a "jump" on hover. Probably somewhere you set/remove a border that causes change of element height.

this is still reproducible. There shouldn't be a "jump" on hover.

InnaAtanasova avatar Mar 24 '25 15:03 InnaAtanasova