fundamental-styles icon indicating copy to clipboard operation
fundamental-styles copied to clipboard

documentation improvements

Open droshev opened this issue 2 years ago • 1 comments

Few improvements:

  • [x] when we go to https://sap.github.io/fundamental-styles/ we don't get redirect to https://sap.github.io/fundamental-styles/?path=/docs/introduction--styles
  • [ ] missing how and what when developers need to import css files related to specific components
  • [ ] popover aria-hidden is not documented as a selector for hiding the popover content

droshev avatar Mar 13 '23 18:03 droshev

  • [ ] It would be nice to have "setup instructions" for npm-based development on this page too. Right now, it only mentions how to embed the content from CDN in the index file. And it says "The compiled CSS for the full library and modules, e.g., core, layout, etc., are distributed via NPM." But it doesn't mention how to use the package itself.
import "@sap-theming/theming-base-content/content/Base/baseLib/sap_fiori_3/css_variables.css"
import "fundamental-styles/dist/theming/sap_fiori_3.css"

IObert avatar Mar 13 '23 20:03 IObert