fundamental-styles icon indicating copy to clipboard operation
fundamental-styles copied to clipboard

combobox: row height is greater than the 2.5 rem specified (Morning Horizon)

Open obc514 opened this issue 2 years ago • 3 comments

Row height is greater than the 2.5 rem specified (Morning Horizon)

obc514 avatar Aug 11 '22 23:08 obc514

Hi @obc514 what do you mean by row? The link you provided is for ComboBox and there I can't see anything mentioned about 2.5rem

The "touch" height of the input control is 40px (2.5rem) and the input itself is 36px (2.25rem) Screen Shot 2022-08-18 at 1 34 19 PM

Here's how it's per specs: Screen Shot 2022-08-18 at 1 36 03 PM

The bottom margin is 0 when the body (list) is open.

As for the body, it's constructed using the List component and the List item height is 2.75rem

InnaAtanasova avatar Aug 18 '22 17:08 InnaAtanasova

@InnaAtanasova I think what is misleading is that the hover state on items that aren't selected exceeds the item height. I had a look at these specs and it looks like you are following the same approach but what is misleading is that in the UI5 cozy implementation, the hover state or highlighted row doesn't exceed 40px. That's why the fundamental implementations stand out a bit.

obc514 avatar Aug 18 '22 21:08 obc514

UI5 cozy implementation

@platon-rov could you check, please?

InnaAtanasova avatar Aug 18 '22 21:08 InnaAtanasova