fundamental-styles icon indicating copy to clipboard operation
fundamental-styles copied to clipboard

Published 20 hours ago • verified publisher icon SAP

Horizon/Quartz Smoke testing

Open droshev opened this issue 2 years ago • 31 comments

  • [ ] Test the components in all themes before the Horizon release.
  • [ ] Distinguish the release blockers
  • [ ] Bug fixes

Browsers for testing:

  • [ ] Firefox - @g-cheishvili
  • [ ] Edge - @platon-rov
  • [ ] Chrome - @InnaAtanasova
  • [ ] Safari - @N1XUS

Themes for testing:

  • [ ] Quartz Light or Dark
  • [ ] Horizon Morning
  • [ ] Horizon Evening
  • [ ] HCB for Horizon or HCW for Horizon

RTL and LTR testing too

Components for testing:

  • [ ] Avatar
  • [ ] Icons
  • [ ] Busy Indicator
  • [ ] Button Components - Badge on Button
  • [ ] Button Components - Button
  • [ ] Button Components - Button Shortcuts
  • [ ] Button Components - Menu Button
  • [ ] Button Components - Segmented Button
  • [ ] Button Components - Toggle Button
  • [ ] Calendar Components - Date Picker
  • [ ] Checkbox
  • [ ] Dialog and Popover Components - Dialog
  • [ ] Dialog and Popover Components - Popover
  • [ ] Dialog and Popover Components - Message Box
  • [ ] Toolbar and Bar
  • [ ] Input Components - Combobox
  • [ ] Input Components - Input Field
    • [ ] Step Input
    • [ ] Input Group
  • [ ] Input Components - Multi Input and Multi Combo
  • [ ] Message Strip
  • [ ] Page and Layout
    • [ ] Dynamic Page
    • [ ] Dynamic Side Content
    • [ ] Flexible Column Layout
    • [ ] Message Page
    • [ ] Page
  • [ ] Radio Button
  • [ ] Switch
  • [ ] Tab Bar
  • [ ] Text Components
  • [ ] Cards and Tiles
  • [ ] Shellbar
  • [ ] Input Components - Dropdown
  • [ ] List View
    • [ ] List
    • [ ] GridList
    • [ ] ObjectList
    • [ ] Table

droshev avatar May 25 '22 15:05 droshev

Carryover from #3327

  • [x] #3477
  • [x] #3465
  • [x] #3474
  • [x] Tree, Fiori/Horizon, HC. Focus on the expanders look quite different from all other elements. Also state active is missing. However i didn't find how it should look like, probably we should ask designers about it. EDIT temp solution here before speaking w/ designers: https://github.com/SAP/fundamental-styles/pull/3511 image image

Create a separate issue for future testing and integration with ngx

droshev avatar May 25 '22 15:05 droshev

  • [x] Button: Icon & text example is broken image

FIXED

N1XUS avatar May 31 '22 11:05 N1XUS

  • [x] Horizon carousel: text is not filly visible https://github.com/SAP/fundamental-styles/pull/3513 image

N1XUS avatar May 31 '22 11:05 N1XUS

  • [x] Avatar - the focus is not per specs. - https://github.com/SAP/fundamental-styles/pull/3505 Fund-styles: Screen Shot 2022-06-01 at 2 41 48 PM Screen Shot 2022-06-01 at 2 41 54 PM

Specs: Screen Shot 2022-06-01 at 2 50 10 PM

Fund-styles Avatar Group:

Screen Shot 2022-06-01 at 2 51 53 PM

bring the question in the Horizon thread

InnaAtanasova avatar Jun 01 '22 18:06 InnaAtanasova

  • [x] IconTabBar focus issues (Horizon) https://github.com/SAP/fundamental-styles/pull/3517 Screen Shot 2022-06-01 at 4 18 12 PM Screen Shot 2022-06-01 at 4 17 21 PM Screen Shot 2022-06-01 at 3 56 15 PM Screen Shot 2022-06-01 at 3 54 46 PM

InnaAtanasova avatar Jun 01 '22 20:06 InnaAtanasova

  • [x] Menu focus issues (Horizon) - https://github.com/SAP/fundamental-styles/pull/3510 Screen Shot 2022-06-01 at 4 25 17 PM Screen Shot 2022-06-01 at 4 25 12 PM

  • [x] Disabled Menu element gets a focus: - https://github.com/SAP/fundamental-styles/pull/3510 Screen Shot 2022-06-01 at 4 24 49 PM

InnaAtanasova avatar Jun 01 '22 20:06 InnaAtanasova

  • [x] Micro Process Flow (Horizon) - focus issue: @N1XUS https://github.com/SAP/fundamental-styles/pull/3507 Screen Shot 2022-06-01 at 4 43 51 PM

InnaAtanasova avatar Jun 01 '22 20:06 InnaAtanasova

  • [x] Progress Indicator - issue when the bar is at 0% (Horizon) - https://github.com/SAP/fundamental-styles/pull/3509 Screen Shot 2022-06-01 at 4 47 42 PM

InnaAtanasova avatar Jun 01 '22 20:06 InnaAtanasova

  • [x] Rating indicator focus issue (Horizon) - https://github.com/SAP/fundamental-styles/pull/3508

Fund-styles: Screen Shot 2022-06-01 at 4 55 39 PM

Should be: Screen Shot 2022-06-01 at 4 55 35 PM Screen Shot 2022-06-01 at 4 55 30 PM

InnaAtanasova avatar Jun 01 '22 20:06 InnaAtanasova

  • [x] Select (Horizon) - the focus for the menu elements (first and last element) should be consistent with the Menu and List. https://github.com/SAP/fundamental-styles/pull/3510

Select (Horizon) Screen Shot 2022-06-01 at 4 57 12 PM Screen Shot 2022-06-01 at 4 57 21 PM

Menu (Horizon) Screen Shot 2022-06-01 at 4 58 55 PM Screen Shot 2022-06-01 at 4 58 51 PM

InnaAtanasova avatar Jun 01 '22 20:06 InnaAtanasova

  • [x] Horizontal Navigation (Horizon) focus issues: https://github.com/SAP/fundamental-styles/pull/3510 Screen Shot 2022-06-01 at 5 20 36 PM Screen Shot 2022-06-01 at 5 20 21 PM Screen Shot 2022-06-01 at 5 20 13 PM Screen Shot 2022-06-01 at 5 20 10 PM

InnaAtanasova avatar Jun 01 '22 21:06 InnaAtanasova

  • [x] Select (Horizon) - the focus for the menu elements (first and last element) should be consistent with the Menu and List.

Same issue on multi-input and combobox. I think our official answer is that these fd-lists which are in popover dropdowns actually need to be fd-menu's. The reasoning being that we did not want to couple the list component to the popover. But I think that will require significant changes on both the styles repo and fundamental-ngx

mikerodonnell89 avatar Jun 01 '22 22:06 mikerodonnell89

  • [x] Progress Indicator - issue when the bar is at 0% (Horizon)
Screen Shot 2022-06-01 at 4 47 42 PM

This can not be solved in CSS

g-cheishvili avatar Jun 02 '22 11:06 g-cheishvili

  • [x] Progress Indicator - issue when the bar is at 0% (Horizon)
Screen Shot 2022-06-01 at 4 47 42 PM

This can not be solved in CSS

You can use aria-valuenow for value and apply needed styling

N1XUS avatar Jun 02 '22 12:06 N1XUS

  • [x] Horizon progress indicator: - https://github.com/SAP/fundamental-styles/pull/3509 100% width is not completely a 100% width: image

N1XUS avatar Jun 02 '22 14:06 N1XUS

  • [x] Upload collection with long text - save/edit buttons get vertically stacked won't fix Screen Shot 2022-06-02 at 11 40 46 AM

mikerodonnell89 avatar Jun 02 '22 17:06 mikerodonnell89

  • [x] Breadcrumb does not have an underline on hover https://github.com/SAP/fundamental-styles/pull/3512

InnaAtanasova avatar Jun 02 '22 19:06 InnaAtanasova

  • [x] Upload collection with long text - save/edit buttons get vertically stacked Screen Shot 2022-06-02 at 11 40 46 AM

That's how Platon intended. https://github.com/SAP/fundamental-styles/pull/3227#issuecomment-1076524272

g-cheishvili avatar Jun 03 '22 12:06 g-cheishvili

  • [x] Breadcrumb does not have an underline on hover

I think breadcrumb link element should go. There is no need for it, that is exactly what fd-link is

g-cheishvili avatar Jun 03 '22 12:06 g-cheishvili

  • [x] tool header - button edges are cut off https://github.com/SAP/fundamental-styles/pull/3515 Screen Shot 2022-06-03 at 10 16 44 AM Screen Shot 2022-06-03 at 10 16 47 AM

mikerodonnell89 avatar Jun 03 '22 16:06 mikerodonnell89

  • [x] shellbar - popover not aligned (all themes) Screen Shot 2022-06-03 at 11 40 10 AM

mikerodonnell89 avatar Jun 03 '22 17:06 mikerodonnell89

  • [x] Horizon icon tab bar is missing separators also causing broken focus outline on menu item https://github.com/SAP/fundamental-styles/pull/3518 fiori: Screen Shot 2022-06-03 at 12 21 21 PM

horizon: Screen Shot 2022-06-03 at 12 21 42 PM

mikerodonnell89 avatar Jun 03 '22 18:06 mikerodonnell89

  • [x] card with list - incorrect focus outline. - https://github.com/SAP/fundamental-styles/pull/3542 Screen Shot 2022-06-03 at 2 57 53 PM

mikerodonnell89 avatar Jun 03 '22 21:06 mikerodonnell89

  • [x] shellbar - popover not aligned (all themes) Screen Shot 2022-06-03 at 11 40 10 AM

@mikerodonnell89 it is actually aligned. Menu trigger has own paddings. @droshev @InnaAtanasova should we refactor those trigger controls to exclude margins so that popovers would be aligned to the text and not the container?

image

N1XUS avatar Jun 06 '22 07:06 N1XUS

  • [x] Avatar Group, no paddings on dropdown's input https://github.com/SAP/fundamental-styles/pull/3543
image
  • [x] Quick View, no paddings on inputs https://github.com/SAP/fundamental-styles/pull/3543
image

platon-rov avatar Jun 06 '22 08:06 platon-rov

  • [x] Avatar Group, no paddings on dropdown's input
image
  • [x] Quick View, no paddings on inputs
image

These shouldn't even have the fd-input class in my opinion

mikerodonnell89 avatar Jun 06 '22 21:06 mikerodonnell89

  • [x] Multi Input, outline margins https://github.com/SAP/fundamental-styles/issues/3495#issuecomment-1149148496
image

platon-rov avatar Jun 07 '22 08:06 platon-rov

@mikerodonnell89 it is actually aligned. Menu trigger has own paddings. @droshev @InnaAtanasova should we refactor those trigger controls to exclude margins so that popovers would be aligned to the text and not the container?

image

I think yes for sure

mikerodonnell89 avatar Jun 07 '22 20:06 mikerodonnell89

  • [ ] Multi Input, outline margins
image

So I agree these look a little weird, but they share the same margins as the focus outlines for the other list items and the same border-radius as the parent popover body element. Screenshot below has forced focus on the elements showing that they all do have the same margins Screen Shot 2022-06-07 at 2 36 34 PM

mikerodonnell89 avatar Jun 07 '22 20:06 mikerodonnell89

  • [x] Object Marker, wrong focus state. In wiki said to use Link's focus designs. https://github.com/SAP/fundamental-styles/pull/3587
image

platon-rov avatar Jun 13 '22 13:06 platon-rov