fundamental-react icon indicating copy to clipboard operation
fundamental-react copied to clipboard

FormLegend: refactor to be part of FormFieldset

Open jbadan opened this issue 5 years ago • 0 comments

Description

FormLegend doesn't need to be it's own component, we should make a prop for FormFieldset that populates the legend.

Question: can a <legend> ever be used on it's own? If that answer is no:

  1. Delete FormLegend https://github.com/SAP/fundamental-react/blob/master/src/Forms/FormLegend.js
  2. Move FormLegend functionality into FormFieldset via prop eg:
<FormFieldset legend='my localized legend text' />
<FormFieldset legend={(<h3>my localized text</h3>)} />

Implement according to spec: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/legend ^ might require a change for underlying html in fundamental-styles

Versions

fundamental-react: 0.13.0


NOTE: Where applicable, please include uncropped screen captures.

DISCLAIMER: After triaging an issue, the fundamental-react team will see if it can be reproduced or confirmed. If more information is needed, the fundamental-react team will contact the author. Any issues awaiting responses from the author for more than 7 days will be closed. The author can re-open the issue at a later time if they can present the requested information.

jbadan avatar May 04 '20 19:05 jbadan