Button: ariaLabel prop should be required if no children are passed

Open jbadan opened this issue 5 years ago • 0 comments

Description

Add ariaLabel prop, make mandatory if there is no text in a button

aria-label is currently being spread to Buttons. We should pull this out and enforce having an aria-label for Buttons if there in no text - https://github.com/SAP/fundamental-react/blob/master/src/Button/Button.js#L82

Versions

fundamental-react: 0.13.0

NOTE: Where applicable, please include uncropped screen captures.

DISCLAIMER: After triaging an issue, the fundamental-react team will see if it can be reproduced or confirmed. If more information is needed, the fundamental-react team will contact the author. Any issues awaiting responses from the author for more than 7 days will be closed. The author can re-open the issue at a later time if they can present the requested information.

May 01 '20 22:05 jbadan