fundamental-react icon indicating copy to clipboard operation
fundamental-react copied to clipboard

An emphasized button needs to be bold

Open IObert opened this issue 5 years ago • 4 comments

Describe the bug

An <Button option='emphasized'>Emphasized Button</Button> should have an emphasized font weight. Screen Shot 2020-09-17 at 11 57 53

What version of the Fundamental Library Styles are you using? "fundamental-react": "0.13.0-rc.21",

What offering/product do you work on? Any pressing ship or release dates we should be aware of? Demo

What front-end framework are you implementing in, e.g., Angular, React, etc.? React

Expected behavior Bold label Screen Shot 2020-09-17 at 11 58 51

Screenshots Non bold label in current version Screen Shot 2020-09-17 at 11 59 02

Desktop (please complete the following information):

  • OS: Mac OS
  • Browser Chrome
  • Version Version 85.0.4183.102 (Official Build) (64-bit)

see #SAP/fundamental-styles/issues/1641

IObert avatar Sep 17 '20 10:09 IObert

Hello @IObert, thank you for using fundamental-react! The fundamental-react team will triage your issue as soon as possible.

github-actions[bot] avatar Sep 17 '20 10:09 github-actions[bot]

Hi @rengare, the fd-button__text class which was introduced in https://github.com/SAP/fundamental-styles/pull/1305 is overriding emphasized button styles in such a scenario:

<button class="fd-button fd-button--emphasized" type="button">
    <span class="fd-button__text">Emphasized Button</span>
</button>

I know that fd-button__text is currently only supported for menu button; but is there a quick way we could make this work for normal buttons? For example, we started using this class in our recent fd-react update: https://github.com/SAP/fundamental-react/pull/1203

prsdthkr avatar Sep 22 '20 03:09 prsdthkr

We prefer not to advertise fd-button__text for non menu button so it would be better to be fixed in fd-react

droshev avatar Feb 17 '21 01:02 droshev

Hello @IObert, thank you for using fundamental-react! The fundamental-react team will triage your issue as soon as possible.

github-actions[bot] avatar Feb 17 '21 01:02 github-actions[bot]