fundamental-ngx
fundamental-ngx copied to clipboard
SAP
fix(core,platform): remove platform highlighting and account for lt and gt in highlight pipe
fixes #8631
This is a replacement for #8651
Removes platform's redundant highlighting pipes, and the core highlighting pipe now accounts for < and > which were not being rendered (see linked issue/pr above for more details)
Deploy Preview for fundamental-ngx ready!
| Name | Link |
|---|---|
| Latest commit | 1ce37886ab734d584c58c72482fc403b1ce7ec7e |
| Latest deploy log | https://app.netlify.com/sites/fundamental-ngx/deploys/6333774b5c7d03000956d10f |
| Deploy Preview | https://deploy-preview-8658--fundamental-ngx.netlify.app/docs/fn/input/examples/input-form-group-example.component |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Visit the preview URL for this PR (updated for commit 1ce3788):
https://fundamental-ngx-gh--pr8658-fix-highlight-refact-bi3lknls.web.app
(expires Fri, 30 Sep 2022 22:36:20 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request introduces 2 alerts when merging 3b0c83e7f9b92963f0d1ec46f80fe453ea46a552 into 34da9f09d729dfcf77b3beac478c2b196ed6e89c - view on LGTM.com
new alerts:
- 2 for Incomplete string escaping or encoding
![lgtm-com[bot] avatar](https://avatars.githubusercontent.com/in/17324?v=4 "Published by a pub.dev verified publisher"){kind=small}
@mikerodonnell89 I don't think we can use innerHTML as it will convert any unicode to HTML tag.
dataSource = [
{ name: Apple<hello>, type: 'Fruits' },
{ name: 'Banana>', type: 'Fruits' },
{ name: 'Pineapple', type: 'Fruits' }
];
for datasource even if we use replace functionality it will print as shown in picture below.
@mikerodonnell89 I don't think we can use innerHTML as it will convert any unicode to HTML tag. dataSource = [ { name:
Apple<hello>, type: 'Fruits' }, { name: 'Banana>', type: 'Fruits' }, { name: 'Pineapple', type: 'Fruits' } ]; for datasource even if we use replace functionality it will print as shown in picture below.
This case is addressed when using lodash escape, see the new commit