fundamental-ngx
fundamental-ngx copied to clipboard
[blocked] fix(platform): multi-combobox displayKey name property is taking com…
…plete text
Related Issue(s)
closes #8631
Description
In multi-combobox DisplayKey name property was not taking complete text.
for data={" name:'apple
Screenshots
Before:

After:
Please check whether the PR fulfills the following requirements
During Implementation
- Visual Testing:
- [x] visual misalignments/updates
- [x] check Light/Dark/HCB/HCW themes
- [x] RTL/LTR - proper rendering and labeling
- [x] responsiveness(resize)
- [x] Content Density (Cozy/Compact/(Condensed))
- [x] States - hover/disabled/focused/active/on click/selected/selected hover/press state
- [x] Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
- [x] Mouse vs. Keyboard support
- [x] Text Truncation
- API and functional correctness
- [x] check for console logs (warnings, errors)
- [x] API boundary values
- [x] different combinations of components - free style
- [x] change the API values during testing
- Documentation and Example validations
- [x] missing API documentation or it is not understandable
- [x] poor examples
- [x] Stackblitz works for all examples
- Accessibility testing
- Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality
- [x] the commit message(s) follows the guideline: https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
- [x] tests for the changes that have been done
- [x] all items on the PR Review Checklist are addressed : https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
- [x] Run npm run build-pack-library and test in external application
- [x] update
README.md
- [x] Breaking Changes Wiki
Deploy Preview for fundamental-ngx ready!
Name | Link |
---|---|
Latest commit | 4d3d9f490d36346acdca24d40dd40ed0ef374a93 |
Latest deploy log | https://app.netlify.com/sites/fundamental-ngx/deploys/631a2cde9f83100009291386 |
Deploy Preview | https://deploy-preview-8651--fundamental-ngx.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Visit the preview URL for this PR (updated for commit 4d3d9f4):
https://fundamental-ngx-gh--pr8651-fix-8631-multi-combo-ja4sybhh.web.app
(expires Sun, 11 Sep 2022 18:06:47 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Please see https://github.com/SAP/fundamental-ngx/pull/8658 as an alternative for this pr
@mikerodonnell89 hey, we merged #8658 so can we close this one?