fundamental-ngx icon indicating copy to clipboard operation
fundamental-ngx copied to clipboard

Mobile mode & fullscreen for menu and dialog

Open mikerodonnell89 opened this issue 2 years ago • 0 comments

According to the designs, any mobile menu should be a full-screen dialog. In some instances (see here) the dialog does not have a header. So this needs to be a configurable option of the mobile config.

Also the current implementation has a mobile dialog defaulting to this from menu.component.ts Screen Shot 2022-09-01 at 3 19 56 PM

And in our documentation, the developer provides their own mobileConfig like so: Screen Shot 2022-09-01 at 3 21 15 PM

This does not preserve the default cancel button text, and it's unclear to the developer that they'll need to provide that property to keep the default. So I think there are two action items here:

  • [ ] Mobile menu default config should contain dialogConfig: { mobile: true, fullScreen: true }. i.e. Screen Shot 2022-09-01 at 3 22 28 PM

  • [ ] Mobile config example should show how to extend upon the existing default configuration rather than overwrite it. Or MobileModeConfig should not be an interface as we want to initialize some values for it

Additionally:

  • [ ] After opening the dialog, the initial focus should be set on the dialog and not in the input.
  • [ ] Input cursor should appear only after tapping in the input, and at that point the mobile keyboard should be displayed.

Affected components: This is for any input that also displays a list of results

  • [ ] Combobox (core and platform)
  • [ ] Multi input (core and platform)
  • [ ] Multi combobox (platform)
  • [ ] Search field (platform)
  • [ ] Inputs in the shellbar

may be missing some

mikerodonnell89 avatar Sep 01 '22 21:09 mikerodonnell89