fix: give breadcrumb item in overflow click proxy

[NancyKunath]

Related Issue(s)

closes #8521

Description

Breadcrumb items in overflow are now clickable (again).

Please check whether the PR fulfills the following requirements

During Implementation

1. Visual Testing:

• [x] visual misalignments/updates
• [x] check Light/Dark/HCB/HCW themes
• [x] RTL/LTR - proper rendering and labeling
• [x] responsiveness(resize)
• [x] Content Density (Cozy/Compact/(Condensed))
• [x] States - hover/disabled/focused/active/on click/selected/selected hover/press state
• [x] Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
• [x] Mouse vs. Keyboard support
• [x] Text Truncation

2. API and functional correctness

• [x] check for console logs (warnings, errors)
• [ ] API boundary values
• [ ] different combinations of components - free style
• [ ] change the API values during testing

3. Documentation and Example validations

• [ ] missing API documentation or it is not understandable
• [ ] poor examples
• [ ] Stackblitz works for all examples

4. Accessibility testing
5. Browser Testing - Edge, Safari, Chrome, Firefox

PR Quality

• [x] the commit message(s) follows the guideline: https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
• [ ] tests for the changes that have been done
• [x] all items on the PR Review Checklist are addressed : https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
• [ ] Run npm run build-pack-library and test in external application
• [ ] update README.md
• [ ] Breaking Changes Wiki

[cla-assistant[bot]]

All committers have signed the CLA.

[netlify[bot]]

✅ Deploy Preview for fundamental-ngx ready!

Name	Link
🔨 Latest commit	fcf38f8965388f8ccb595f64df1b13c3846cc214
🔍 Latest deploy log	https://app.netlify.com/sites/fundamental-ngx/deploys/62fe7bab97f5660008bbff40
😎 Deploy Preview	https://deploy-preview-8522--fundamental-ngx.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[g-cheishvili]

I checked https://sap.github.io/fundamental-ngx/#/core/breadcrumb and it works as expected(navigates without issue)

v0.35.4

[NancyKunath]

I added a gif showing the bug to the issue #8521. Please have a look.

[g-cheishvili]

I checked it out. You are right.

Just solution is not quite on point. _needsClickProxy is an internal thing, its usage should be changed, instead of name, underscore is important:

this should be in libs/core/src/lib/breadcrumb/breadcrumb.component.ts:125

itemClicked(breadcrumbItem: BreadcrumbItemComponent, $event: any): void {
      if (breadcrumbItem._needsClickProxy) {
          $event.preventDefault();
          breadcrumbItem.breadcrumbLink.elementRef().nativeElement.click();
      }
  }

[NancyKunath]

Okay. I added the underscore again.

[github-actions[bot]]

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

[mikerodonnell89]

Closing in favor of #8599