fundamental-ngx
fundamental-ngx copied to clipboard
SAP
fix(core): action-sheet focus bug
Related Issue(s)
closes #8344
Description
- Added tab key handling.
- Solved focus-lost on close for Mobile view.
Deploy Preview for fundamental-ngx ready!
| Name | Link |
|---|---|
| Latest commit | 3d0f26368ce44b0d3f7e66526bbdaa0b90fcf336 |
| Latest deploy log | https://app.netlify.com/sites/fundamental-ngx/deploys/6303fa06ecda5400086f4680 |
| Deploy Preview | https://deploy-preview-8458--fundamental-ngx.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Visit the preview URL for this PR (updated for commit 3d0f263):
https://fundamental-ngx-gh--pr8458-fix-8344-action-shee-ybuf49e7.web.app
(expires Thu, 25 Aug 2022 22:00:17 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days
the first item in the list doesn't get focused after action sheet dialog opens, is it the intended behavior?
Yes, to give clear visual appearance in mobile mode. Users can focus first element using tab key if they use keyboard. Let me know your thoughts.