fundamental-ngx icon indicating copy to clipboard operation
fundamental-ngx copied to clipboard

fdp datepicker - Value state "warning/info/error" aria message is static

Open prasad-userdev opened this issue 2 years ago • 3 comments

Is this a bug, enhancement, or feature request?

bug

Which versions of Angular and Fundamental Library for Angular are affected? (If this is a feature request, use current version.)

Angular version - 13 ngx - 0.33.4

If this is a bug, please provide steps for reproducing it.

Enter an invalid entry in the date picker and you can observe a red border on the input and "Value State Error" gets read in the JAWS speech history.

Please provide relevant source code if applicable.

<fdp-date-picker name="exampleDate" placeholder="Select a date"
                               dateInputLabel="{{fieldName}}"
                               valueStateErrorMessage ="Invalid entry"  -> @Input valueStateErrorMessage has hardcoded value 
                                [(ngModel)]="dateFdValue"
                                (ngModelChange)="onFieldDateChange(customField)">
</fdp-date-picker>

Is there anything else we should know?

image

prasad-userdev avatar Jun 11 '22 17:06 prasad-userdev

Can you provide more details? like what is the expected behavior?

fkolar avatar Aug 24 '22 14:08 fkolar

In fdp datepicker, warning, error and Info messages are hardcoded. Just to elaborate, If custom messages need to be set then we need to enable property binding for these attributes. Thanks!

prasad-userdev avatar Aug 24 '22 15:08 prasad-userdev

@prasad-userdev

I would not say they are hardcoded, we can say they have default value and you have options to set your own warning message. But there was always a problem with i18n.

Fundamentals already changed this and code looks already different. What I see fdp-datepicket needs to be updated to catch up with current date picket:

  1. use message binding
  2. Extends demo app for i18n sample

fkolar avatar Aug 25 '22 16:08 fkolar