SAP
chore: remove lodash
lodash is outdated took it's also creating problems with vitest so it's better not to have it
Deploy Preview for fundamental-ngx ready!
| Name | Link |
|---|---|
| Latest commit | be34b39d1664bca85ca30694cb168f018ba8f2b6 |
| Latest deploy log | https://app.netlify.com/projects/fundamental-ngx/deploys/693c9cb318756f0008beabf2 |
| Deploy Preview | https://deploy-preview-13645--fundamental-ngx.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
@robertIsaac Thank you for the contribution. Could you give us some time to discuss and review it thoroughly?
Yes take your time to decide But if you don't want to merge this you need to give us a way to use fundamentals with vitest Because right now it throws errors
Yes take your time to decide But if you don't want to merge this you need to give us a way to use fundamentals with vitest Because right now it throws errors
@robertIsaac if it is not something internal, do you think you can give us more context?
Creating a new Angular project (which uses vitest by default) and importing any of the components that uses lodash will break the unit test I have a reprod, I will push it to GitHub and share it with you
@droshev here is the reprod https://github.com/robertIsaac/reprod-vitest-fundamental.git and here is the problem
Error: Cannot find module '/Users/I755229/temp/reprod-vitest-fundamental/node_modules/lodash-es/get' imported from /Users/I755229/temp/reprod-vitest-fundamental/node_modules/@fundamental-ngx/core/fesm2022/fundamental-ngx-core-multi-input.mjs
Did you mean to import "lodash-es/get.js"?