fundamental-ngx icon indicating copy to clipboard operation
fundamental-ngx copied to clipboard

fix(core) Add Support for Multi-line Messages in Select Component Dropdown

Open khotcholava opened this issue 1 year ago • 3 comments

fix(core): Add Support for Multi-line Messages in Select Component Dropdown

closes #11430

Description

  • Refactored the select component to manage text display mode.
  • Adjusted padding in the select component message to eliminate unnecessary space.
  • Introduced a new input property, textOverflow, to control how text is displayed in the dropdown list, allowing for either ellipsis or full text.

After

Screenshot 2024-10-18 at 02 39 57

khotcholava avatar Oct 17 '24 22:10 khotcholava

Deploy Preview for fundamental-ngx ready!

Name Link
Latest commit 4ca59b32513841be7fa5bcbc7a547c51ece069df
Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/671192ce70de5c0008330834
Deploy Preview https://deploy-preview-12596--fundamental-ngx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 17 '24 22:10 netlify[bot]

Deploy Preview for fundamental-ngx ready!

Name Link
Latest commit 08c60368cc3c937ef42660a2c13e0f299c7ff253
Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6720eb69d628840008e06bd8
Deploy Preview https://deploy-preview-12596--fundamental-ngx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 17 '24 22:10 netlify[bot]

Visit the preview URL for this PR (updated for commit 08c6036):

https://fundamental-ngx-gh--pr12596-11430-fix-select-for-ffhp79qa.web.app

(expires Fri, 01 Nov 2024 14:08:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

github-actions[bot] avatar Oct 17 '24 22:10 github-actions[bot]

Is it intentional that this change introduces additional whitespace when there is no value state text at all? https://github.com/SAP/fundamental-ngx/issues/12810

LukasHeimann avatar Dec 04 '24 07:12 LukasHeimann

there should not be any extra space

droshev avatar Mar 19 '25 15:03 droshev