fundamental-ngx
fundamental-ngx copied to clipboard
fix(platform): icon-tab-bar _generateTabBarItems function improvement
Related Issue(s)
closes #12474 #12554
Description
Screenshots
Before:
After:
Please check whether the PR fulfills the following requirements
During Implementation
- Visual Testing:
- [ ] visual misalignments/updates
- [ ] check Light/Dark/HCB/HCW themes
- [ ] RTL/LTR - proper rendering and labeling
- [ ] responsiveness(resize)
- [ ] Content Density (Cozy/Compact/(Condensed))
- [ ] States - hover/disabled/focused/active/on click/selected/selected hover/press state
- [ ] Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
- [ ] Mouse vs. Keyboard support
- [ ] Text Truncation
- API and functional correctness
- [ ] check for console logs (warnings, errors)
- [ ] API boundary values
- [ ] different combinations of components - free style
- [ ] change the API values during testing
- Documentation and Example validations
- [ ] missing API documentation or it is not understandable
- [ ] poor examples
- [ ] Stackblitz works for all examples
- Accessibility testing
- Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality
- [ ] the commit message(s) follows the guideline: https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
- [ ] tests for the changes that have been done
- [ ] all items on the PR Review Checklist are addressed : https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
- [ ] Run npm run build-pack-library and test in external application
- [ ] update
README.md - [ ] Breaking Changes Wiki
Deploy Preview for fundamental-ngx ready!
| Name | Link |
|---|---|
| Latest commit | e865ce1302588c946cc1e8a3e5d8e267fce4156d |
| Latest deploy log | https://app.netlify.com/sites/fundamental-ngx/deploys/672006a81abef6000808efd5 |
| Deploy Preview | https://deploy-preview-12581--fundamental-ngx.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Visit the preview URL for this PR (updated for commit e865ce1):
https://fundamental-ngx-gh--pr12581-12474-icon-tab-bar-o-yjqnn1zp.web.app
(expires Thu, 31 Oct 2024 21:52:50 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff