fundamental-ngx
fundamental-ngx copied to clipboard
fix(platform): platform table border fix
fix(platform): table ensure all borders are hidden when border options are enabled
closes #10729
Description
This fix addresses the issue where vertical and horizontal borders are still displayed in the Platform Table component, despite enabling the noHorizontalBorders, noVerticalBorders, noBorders, noOuterBorders, and noBodyBorders options. Specifically:
- Removed the vertical border before the last column.
- Removed the horizontal border below the table header when border-hiding options are applied.
Before
After
Deploy Preview for fundamental-ngx ready!
| Name | Link |
|---|---|
| Latest commit | 293cf4eac2d7a2bdb37c0d25a6ab4067e068b529 |
| Latest deploy log | https://app.netlify.com/sites/fundamental-ngx/deploys/6720eb7ceeda9a00086afaf7 |
| Deploy Preview | https://deploy-preview-12555--fundamental-ngx.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Visit the preview URL for this PR (updated for commit 293cf4e):
https://fundamental-ngx-gh--pr12555-10729-table-border-f-kz7a0cye.web.app
(expires Fri, 01 Nov 2024 14:09:22 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff
@mikerodonnell89 I noticed that the noOuterBorder checkbox isn't selected on your screen, which is why the outer borders are visible.
Regarding the header toolbar, its bottom border is part of the toolbar design. Would you like us to handle that on our end as well?
Regarding the header toolbar, its bottom border is part of the toolbar design. Would you like us to handle that on our end as well?
Nope, I think if that is coming from the toolbar then no class on the table should affect it, so this is all looking good