fundamental-ngx icon indicating copy to clipboard operation
fundamental-ngx copied to clipboard

Published 20 hours ago • verified publisher icon SAP

fix(core): address Avatar Group issues

Open khotcholava opened this issue 1 year ago • 2 comments

fix(core): Resolve focus retention & rendering issues, add feature enhancements

Closes #12369

Description

  • Fixed focus bug where focus remained on the first avatar group control after interacting with the second one.
  • Fixed rendering issue where only "+n more" button displayed after switching tabs instead of the full avatar group row.
  • Added feature to open group popover from the center of the avatar group.
  • Added configuration option to make "+n more" button circular to match avatars typically being in circle shapes.
  • Introduced property to set the number of visible avatars before displaying the "+n more" button.

khotcholava avatar Oct 10 '24 11:10 khotcholava

Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys

Name Link
Latest commit 34205643618f3e47f9cd00508d24eac91b658c5b
Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6776d3def1388300088ec47e

netlify[bot] avatar Oct 10 '24 11:10 netlify[bot]

Visit the preview URL for this PR (updated for commit 3420564):

https://fundamental-ngx-gh--pr12530-fix-core-avatar-gro-0buuy2zc.web.app

(expires Sun, 05 Jan 2025 18:03:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

github-actions[bot] avatar Oct 10 '24 11:10 github-actions[bot]

@mikerodonnell89 In this example, the web components avatar group features tab navigation but lacks arrow navigation.

I'm currently working on implementing tab navigation.

khotcholava avatar Oct 24 '24 07:10 khotcholava

@mikerodonnell89 Implemented arrow navigation.

khotcholava avatar Oct 25 '24 09:10 khotcholava

@mikerodonnell89 Have you checked latest version? This is locally on my end.

https://github.com/user-attachments/assets/473e5a67-8c74-4bbc-810b-d43a9d18bbd7

khotcholava avatar Nov 07 '24 16:11 khotcholava

@mikerodonnell89 @dpavlenishvili Can you review it again?

droshev avatar Nov 20 '24 14:11 droshev

@dpavlenishvili any update?

droshev avatar Nov 25 '24 19:11 droshev

@khotcholava Can you check the e2e?

droshev avatar Nov 27 '24 16:11 droshev

@khotcholava needs to update with the comments from UX, check e2e/unit and make it as PR. Needs to be reviewed afterwards

droshev avatar Dec 18 '24 15:12 droshev

@khotcholava needs to update with the comments from UX, check e2e/unit and make it as PR. Needs to be reviewed afterwards

droshev avatar Dec 19 '24 13:12 droshev

@khotcholava Can you summarize what you did and what needs to be implemented?

droshev avatar Dec 20 '24 14:12 droshev

Closing as this is quite dated - we will need to readdress #12369

mikerodonnell89 avatar Feb 03 '25 21:02 mikerodonnell89