fundamental-ngx
fundamental-ngx copied to clipboard
fix(platform): Combine Sorting, Filtering, and Grouping Settings into a Single Dialog
Related Issue(s)
closes #12441 #12447 #12181
Description
This PR refactors the TableViewSettingsDialogComponent to combine sorting, filtering, and grouping functionality into a single dialog. Previously, sorting, filtering, and grouping were handled by separate dialogs, but now they are merged for a more streamlined user experience. This also reduces code duplication and improves maintainability.
Key changes:
- Created a combined settings dialog for table view settings.
- Refactored the sorting, filtering, and grouping functionalities using Angular signals for optimized state management.
- Added support for sorting, filtering, and grouping in one interface.
- Removed the logic from the individual sorting, filtering, and grouping dialogs and merged it into one component.
- Updated tests to reflect the new combined dialog structure.
- Adjusted documentation and examples to reflect the new functionality.
Screenshots
Before:
After:
https://github.com/user-attachments/assets/8e133f3c-7a42-459a-b0e1-e373615e9c83
Deploy Preview for fundamental-ngx ready!
| Name | Link |
|---|---|
| Latest commit | 574d034c72ebeb1ed890c31d28c6b0c040d43909 |
| Latest deploy log | https://app.netlify.com/sites/fundamental-ngx/deploys/67ae3dcfc390b30008ff6410 |
| Deploy Preview | https://deploy-preview-12502--fundamental-ngx.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Visit the preview URL for this PR (updated for commit db15a70):
https://fundamental-ngx-gh--pr12502-12441-table-settings-gru2ilvf.web.app
(expires Sat, 08 Feb 2025 18:17:23 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff
@dpavlenishvili Great work! few comments:
-
Can you clean up the data in the table dialogs to match the table data? Examples(Initial State):
the status in the dialog has 2 options, but in the table are more:
-
What do we do with the sorting dialog?
@dpavlenishvili Great work! few comments:
- Can you clean up the data in the table dialogs to match the table data? Examples(Initial State):
![]()
the status in the dialog has 2 options, but in the table are more:
- What do we do with the sorting dialog?
i updated all examples
@dpavlenishvili resolve the conflicts, check unit/e2e. Apart from that nothing else is remaining.
@dpavlenishvili check unit/e2e.
the status in the dialog has 2 options, but in the table are more:

