fundamental-ngx icon indicating copy to clipboard operation
fundamental-ngx copied to clipboard

fix(core): default height missing for dynamic page content component

Open dreamweiver opened this issue 4 months ago • 6 comments

Related Issue(s)

closes #https://github.com/SAP/fundamental-ngx/issues/11877

Description

Dynamic Page Content component doesn't have a default height associated with it and hence the child elements which depend on relative sizing like "fdp-table" component is not able to compute the dynamic height for the sticky headers on the fdp-table

here is an example of the stackblitz with the fix(explicitly setting height 100% on <fd-dynamic-page__content>`

Screenshots

Before the fix,

https://github.com/user-attachments/assets/f8bb3896-a9ef-419c-8c55-ed98632019bb

After setting the default height on the fd-dynamic-page__content component,

https://github.com/user-attachments/assets/472cea2c-f6bd-459a-8f2f-bee1bc80599c

Before:

After:

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • [x] visual misalignments/updates
  • [x] check Light/Dark/HCB/HCW themes
  • [x] RTL/LTR - proper rendering and labeling
  • [x] responsiveness(resize)
  • [x] Content Density (Cozy/Compact/(Condensed))
  • [x] States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • [x] Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • [x] Mouse vs. Keyboard support
  • [x] Text Truncation
  1. API and functional correctness
  • [x] check for console logs (warnings, errors)
  • [x] API boundary values
  • [x] different combinations of components - free style
  • [x] change the API values during testing
  1. Documentation and Example validations
  • [x] missing API documentation or it is not understandable
  • [x] poor examples
  • [x] Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality
  • [x] the commit message(s) follows the guideline: https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
  • [x] tests for the changes that have been done
  • [x] all items on the PR Review Checklist are addressed : https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
  • [x] Run npm run build-pack-library and test in external application
  • [x] update README.md
  • [x] Breaking Changes Wiki

dreamweiver avatar Sep 30 '24 10:09 dreamweiver