fundamental-ngx icon indicating copy to clipboard operation
fundamental-ngx copied to clipboard

feat(platform): move the column reordering button in the list item representing the column

Open shawchandankumar opened this issue 1 year ago • 6 comments

Currently, the column reorder button is in the personalization dialog toolbar, which doesn't clearly show which of the following list items is active. By moving the reordering buttons on an individual list item whichever list item is currently active, it shows the reordering buttons for that particular list item.

Closes #12175

Before:

image

After:

image

shawchandankumar avatar Aug 23 '24 04:08 shawchandankumar

Deploy Preview for fundamental-ngx ready!

Name Link
Latest commit 489f53e1d349b82bc420fa408d91ba0027d123aa
Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/66cf5c1dfe00000008dc6308
Deploy Preview https://deploy-preview-12300--fundamental-ngx.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 23 '24 04:08 netlify[bot]

Visit the preview URL for this PR (updated for commit 489f53e):

https://fundamental-ngx-gh--pr12300-feat-fdp-table-toolb-npllgviv.web.app

(expires Sat, 31 Aug 2024 17:23:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

github-actions[bot] avatar Aug 23 '24 04:08 github-actions[bot]

@shawchandankumar The functionality differs from the UI5 implementation of the personalization table. In UI5, sorting arrows are visible on hover, while in your version, the arrows only appear when a row is selected. As a result, column sorting is not possible without re-selecting the row in your implementation.

khotcholava avatar Aug 26 '24 20:08 khotcholava

Looking better but why does the move-row-up button lose focus after pressing enter?

mikerodonnell89 avatar Aug 27 '24 18:08 mikerodonnell89

Looking better but why does the move-row-up button lose focus after pressing enter?

It's because of rendering differently after a change I believe. In move down button it's not happening

shawchandankumar avatar Aug 28 '24 06:08 shawchandankumar

Looking better but why does the move-row-up button lose focus after pressing enter?

@mikerodonnell89 Is it good now?

shawchandankumar avatar Aug 29 '24 17:08 shawchandankumar