fundamental-ngx icon indicating copy to clipboard operation
fundamental-ngx copied to clipboard

Multiple Icons listed with fd-menu-addon

Open AnkitSomani22 opened this issue 1 year ago • 2 comments

Is this a bug, enhancement, or feature request? :

Bug

Describe your proposal. :

Multiple Icons are getting listed in fd-menu-addon after upgrade of fundamental ngx to 0.46.1 from 0.45.1 though there is no source code changed. It is found that sporadically multiple icons are listed in a menu item where one icon would be the icon which glyph is passed and other icons would be wither the same glyph or repeated from other menu-item in same menu. This issue is also there in fundamental ngx library version 0.47.1 as well.

Screenshot 2024-02-02 at 1 51 31 PM

Can you handle that on the application side :

No

Which versions of Angular and Fundamental Library for Angular are affected?

Please, specify the exact version. (If this is a feature request, use current version.) : 0.46.1

If this is a bug, please provide steps for reproducing it; the exact components you are using; :

It is sporadic issue where sometime we are seeing multiple icons in fd-menu-addon.

Please provide relevant source code (if applicable).

<fd-menu>
    <li *ngFor="let item of items; trackBy: trackBy" fd-menu-item>
      <a fd-menu-interactive>
        <fd-menu-addon [position]="'before'" [glyph]="item.glyph"></fd-menu-addon>
        <span fd-menu-title>{{ item.title }}</span>
      </a>
    </li>
</fd-menu>

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Did you check the documentation and the API? : yes

Did you search for similar issues? : yes, Not found

Is there anything else we should know?

After refresh of UI this issue is not replicable. I think here isfd-icon is not getting destroyed in fd-menu-addon.

AnkitSomani22 avatar Feb 02 '24 08:02 AnkitSomani22

Hi @AnkitSomani22 , thank you for opening the issue! I have tried to recreate this issue but I couldn't. You mention in the issue that you were able to reproduce it in our documentation. Which component was that. Here are some screenshots of Stackblitz with Action Bar component using version 0.47.4. Screenshot 2024-02-05 at 1 30 59 PM Screenshot 2024-02-05 at 1 31 12 PM

InnaAtanasova avatar Feb 05 '24 18:02 InnaAtanasova

Here's the same example with version 0.46.1: Screenshot 2024-02-05 at 1 36 22 PM Screenshot 2024-02-05 at 1 36 11 PM

InnaAtanasova avatar Feb 05 '24 18:02 InnaAtanasova

@AnkitSomani22 We didn't get any further update. Can you create a stackblitz with the issue and report a new issue?

droshev avatar Mar 03 '24 12:03 droshev