fundamental-ngx icon indicating copy to clipboard operation
fundamental-ngx copied to clipboard

[Sourcing-2][Accessibility: ACC-264.1] Icon: Label not read

Open JyotiKumari1507 opened this issue 1 year ago • 2 comments

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

Component having issue: https://sap.github.io/fundamental-ngx/#/platform/table/basic Table with Filer: The Back button of Filter dialog when we click Filter by is just mentioned as "toggle button' and label is not mentioned. Label for the UI must be mentioned.

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

All latest version

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Using Screen reader can check by implementing similar case. Just use table with Filter on toolbar. click filter icon .to open there respective dialog popup. click filter by any attribute. The Back button visible will be just mentioned as "toggle button' and label is not mentioned.

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Yes we have got this bug from Accessibility expert only.

Did you check the documentation and the API?

Yes

Did you search for similar issues?

Is there anything else we should know?

Refer attachement :

Screenshot 2024-01-21 at 4 29 47 PM

JyotiKumari1507 avatar Jan 21 '24 11:01 JyotiKumari1507

Hi @droshev,

The icon only back button needs to have a label according to Fiori: image

Please after adding the label check if it is interpreted as accessibleName of the button. If not, you need to add the same tooltip text in the aria-label attribute.

Best Regards, Nikolay

nikolay-kolarov avatar Feb 02 '24 16:02 nikolay-kolarov

@droshev Please find the attached screen shot where The Back button is readout as "toggle button' by screen reader and label is not mentioned.. this filter dialog box is of platform table. we can't edit lable of back button image

JyotiKumari1507 avatar Feb 05 '24 16:02 JyotiKumari1507

Most of the fields are not filled.

droshev avatar Feb 29 '24 22:02 droshev

@droshev please let us know what pending from our side.

JyotiKumari1507 avatar Mar 19 '24 10:03 JyotiKumari1507

We need to set aria-label="Navigate Back" title="Navigate Back"

droshev avatar Mar 21 '24 19:03 droshev

@droshev please let me know which NGX version will have this fix

JyotiKumari1507 avatar Apr 18 '24 12:04 JyotiKumari1507

@droshev waiting for response

JyotiKumari1507 avatar May 06 '24 05:05 JyotiKumari1507

We need to set aria-label="Navigate Back" title="Navigate Back"

@droshev as its ngx inbuilt code so we can't set these attribute from our side. Its should be added by your team so requesting to re-open this ticket

JyotiKumari1507 avatar May 06 '24 05:05 JyotiKumari1507

@droshev this should be replaced with [ariaLabel]="'platformTable.filterDialogBackToColumns' | fdTranslate" because of this

g-cheishvili avatar May 06 '24 05:05 g-cheishvili

@g-cheishvili @droshev can you please re-open this ticket, we have been asking to re-open from long time

JyotiKumari1507 avatar Jul 19 '24 08:07 JyotiKumari1507

you can report a new ticket with more details if needed

droshev avatar Jul 19 '24 14:07 droshev