fundamental-ngx icon indicating copy to clipboard operation
fundamental-ngx copied to clipboard

[Sourcing-2][Accessibility: ACC-264.1][WIP] Within settings dialog , User redirected to dialog not conveyed.

Open JyotiKumari1507 opened this issue 1 year ago • 13 comments

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

https://sap.github.io/fundamental-ngx/#/platform/settings-generator. Within NGX platform settings , When the user activates 'Settings' UI and the user is redirected to a dialog, the same info must be conveyed by screen reader.

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

All latest version

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Using Screen reader easily can check NGX platform settings, by clicking setting dialog open for settings but same isn't conveyed by screen reader’.

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Yes we have got this bug from Accessibility expert only.

Did you check the documentation and the API?

Yes

Did you search for similar issues?

Is there anything else we should know?

JyotiKumari1507 avatar Jan 21 '24 09:01 JyotiKumari1507

Hi @JyotiKumari1507,

Could you please provide more info where you observed this? I tested the last sample: image And the dialog was correctly announced.

Thanks, Nikolay

nikolay-kolarov avatar Feb 02 '24 13:02 nikolay-kolarov

@nikolay-kolarov @droshev When the user activates the 'settings' UI, the user is redirected to a dialog, but the same info is not conveyed to the user by screen reader. please refer attached screenshot

image

JyotiKumari1507 avatar Feb 05 '24 16:02 JyotiKumari1507

Hi @droshev, Hi @JyotiKumari1507,

As said, I tested the dialog on the provided test page and there the dialog role is announced. So then the respective app can be checked if they use the same UI version, and the same component, and why it is not announced there.

Best Regards, Nikolay

nikolay-kolarov avatar Feb 08 '24 12:02 nikolay-kolarov

@droshev @nikolay-kolarov This issue may fix with NGX upgrade. If you want mean while i can get recording from accessibility team also.

JyotiKumari1507 avatar Feb 12 '24 04:02 JyotiKumari1507

Most of the fields are not filled.

droshev avatar Feb 29 '24 22:02 droshev

@droshev please let us know what fields are pending to fill from our side

JyotiKumari1507 avatar Mar 19 '24 10:03 JyotiKumari1507

@JyotiKumari1507 can you create either stackblitz or share the steps how to reproduce the issue and what the expected behavior is?

droshev avatar May 22 '24 20:05 droshev

@JyotiKumari1507 Can you create a stackblitz example, steps to reproduce and what the expectation is? Otherwise we will close the ticket.

droshev avatar Jun 11 '24 11:06 droshev

Hi @droshev, you can try with the example here

Click on user avatar-> Go to Settings -> Dialog popup is not conveyed in screen reader.

divyamalhotra488 avatar Jul 31 '24 14:07 divyamalhotra488

@divyamalhotra488 why can't you add whatever you need to the dialog template?

droshev avatar Aug 02 '24 18:08 droshev

Hi @droshev, UI wise it looks okay. The issue is that the dialog being opened is not conveyed by the screen reader. This is violating accessibility standard.

divyamalhotra488 avatar Aug 05 '24 05:08 divyamalhotra488

@divyamalhotra488 you have the control of the dialog, so you can set anything needed.

droshev avatar Aug 05 '24 14:08 droshev

@droshev, could you please suggest what attribute to set for screen reader to recognise dialog being opened ?

divyamalhotra488 avatar Aug 06 '24 12:08 divyamalhotra488