fundamental-ngx icon indicating copy to clipboard operation
fundamental-ngx copied to clipboard

[Sourcing-2][Accessibility: ACC-264.1][WIP] All NGX 'Button' or 'Button menu' are provided with role 'Toggle button' and is incorrect.

Open JyotiKumari1507 opened this issue 1 year ago • 10 comments

Is this a bug, enhancement, or feature request?

bug

Describe your proposal.

All NGX core and Platform 'Button' or 'Button menu' are provided with role 'Toggle button' and is incorrect.... Every Button and Button Menu of NGX core and Platform is read out by screen reader as 'Toggle button'. Even though we have not used 'Toggle button' any places . Its coming from NGX component

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

Accessibility expert

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Using Screen reader easily can check all Button and Button menu is readout as "toggle button".

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Yes we have got this bug from Accessibility expert only.

Did you check the documentation and the API?

Yes

Did you search for similar issues?

Is there anything else we should know?

JyotiKumari1507 avatar Jan 21 '24 08:01 JyotiKumari1507

@JyotiKumari1507 we would need some specific examples. In general you should test our documentation page for accessibility as it is more created for the developers to explore the cases and the API.

BTW, in the first example of the buttons I see the button being written:

Screenshot 2024-01-30 at 14 32 14 I couldn't spot any toggle labels

droshev avatar Jan 30 '24 19:01 droshev

@droshev Toggle button is read out by Screen reader for Button and Menu button every where while testing by Accessibility Team even though we have not used this word anywhere . Lets discuss about this in our next call

JyotiKumari1507 avatar Jan 31 '24 03:01 JyotiKumari1507

@JyotiKumari1507 we need the input written so it will be easier to process

droshev avatar Jan 31 '24 14:01 droshev

@droshev Attaching screen reader screenshot for more details: image image image

JyotiKumari1507 avatar Feb 05 '24 16:02 JyotiKumari1507

Most of the fields are not answered. We can't analyze from screenshots

droshev avatar Feb 29 '24 22:02 droshev

@droshev please let us know what fields are pending to fill from our side. I think I have shared all details already. Lets have call if still issue isn't explained well

JyotiKumari1507 avatar Mar 19 '24 10:03 JyotiKumari1507

@JyotiKumari1507 did you set all aria attributes needed? If so, can you create a small stackblitz example demonstrating that you cannot set this on the application side?

droshev avatar Mar 21 '24 19:03 droshev

@divyamalhotra488 please share stackblitz example

JyotiKumari1507 avatar Apr 19 '24 06:04 JyotiKumari1507

@JyotiKumari1507 any update?

droshev avatar May 22 '24 20:05 droshev

Hi @droshev, please find stackblitz example here: https://stackblitz.com/edit/vkz16p?file=src%2Fapp%2Fbutton-types-example.component.html

divyamalhotra488 avatar May 29 '24 04:05 divyamalhotra488