fundamental-ngx icon indicating copy to clipboard operation
fundamental-ngx copied to clipboard

Combobox Issue when used in Reactive Form

Open pranay-gupta-01 opened this issue 1 year ago • 1 comments

Is this a bug, enhancement, or feature request?

Bug

Describe your proposal.

  1. When using [communicateByObject]="true" with custom objects for dropdownValues, clicking on a dropdown item is not updating the form's value.
  2. Once a particular value is selected from dropdownValues, the other options using the dropdown arrow disappear and the only way to make a selection again is to erase the currently selected value using the cursor.

The above is not observed with the same implementation when using fd-select.

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

Angular: 16.2.12 NGX: 0.46.1

If this is a bug, please provide steps for reproducing it; the exact components you are using;

These are observed when using fd-combobox with reactive form. Specifically, when [communicateByObject]="true" is used with custom objects for dropdownValues, the form value is not updated on the first try, but this goes away on subsequent tries. Please refer to the recordings for more info.

Please provide relevant source code (if applicable).

https://github.com/SAP/fundamental-ngx/assets/155584127/8d73ccf1-f5c1-4e44-acd6-085de5ee70f4

https://github.com/SAP/fundamental-ngx/assets/155584127/ee07c195-a50e-423f-94c0-1f6e324a90ed

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

NA

Did you check the documentation and the API?

Yes

Did you search for similar issues?

Yes

Is there anything else we should know?

pranay-gupta-01 avatar Jan 05 '24 15:01 pranay-gupta-01

Hello @pranay-gupta-01. Could you please provide a stackblitz example so we could analyze source code of this recordings? It will definitely help us to speed things up a lot.

N1XUS avatar Feb 23 '24 07:02 N1XUS

@pranay-gupta-01 Can you follow up with @N1XUS request?

droshev avatar Mar 02 '24 15:03 droshev

Hello @N1XUS, I've been trying to use the stackblitz examples linked in the fundamental library page, but they don't seem to be compiling. Do you have a working stackblitz with the fundamental library dependencies I can use to illustrate the bug? Thank you.

pranay-gupta-01 avatar Mar 04 '24 18:03 pranay-gupta-01