cloud-sdk icon indicating copy to clipboard operation
cloud-sdk copied to clipboard

HttpClient Middleware is not a middleware

Open nazarkulyk opened this issue 1 year ago • 1 comments

Please review your concept for http client adapter and documentation for it on:

https://sap.github.io/cloud-sdk/docs/js/features/middleware#benefits-of-middlewares

Let us know how we can improve

Providing custom adapter to make own http requests over node-fetch, undici or other API should be called as "adapter" and not "middleware". Middleware is something you will chain to work on http response. You are providing adapter on this place...

Thanks

nazarkulyk avatar Jun 07 '24 08:06 nazarkulyk

image

nazarkulyk avatar Jun 07 '24 08:06 nazarkulyk