cloud-sdk-js icon indicating copy to clipboard operation
cloud-sdk-js copied to clipboard

feat: improve support for IAS tokens

Open marikaner opened this issue 1 year ago • 1 comments

This includes generalized handling of tokens so that XSUAA, IAS and other custom tokens.

I fixed some places to make sure the difference between subdomain (aka. tenant, aka. tenant name) and tenant ID (aka. zone ID, aka. app_tid) is hopefully more obvious and in some cases more correct. Especially the subdomain needs to be handled differently between XSUAA and IAS.

Closes SAP/cloud-sdk-backlog#1219. Closes SAP/cloud-sdk-backlog#1217.

marikaner avatar Jun 28 '24 14:06 marikaner

Please take my comments with a grain of salt, since the code is so complicated and I don't understand much if any of it. Comments are only based on the diff, not much else 😅

No worries! Thanks for the review! 😊

marikaner avatar Jun 28 '24 15:06 marikaner