abap-cleaner icon indicating copy to clipboard operation
abap-cleaner copied to clipboard

Highlight of opened rule is very weak in dark mode

Open ConjuringCoffee opened this issue 1 year ago • 2 comments

Hi Jörg-Michael, I find that the indicator for a currently opened rule is very weak (after clicking into the examples or options). I sometimes find myself lost in the list of rules because of that!

I've had a look at the documentation, and it seems like this is how it looks like in light mode:

image

However, here's how it looks like in dark mode (selecting the rule and then clicking into the examples or options): image

Can you still see it? 😉

This is especially disorienting when working with the highlight functionality. Here's how it looks like before selecting it:

image

Here's what it looks like after selecting it:

image

Then clicking into the options or examples:

image

It would be great if the green highlight was still discernable after selecting the rule.

ConjuringCoffee avatar Mar 25 '24 14:03 ConjuringCoffee

Hi ConjuringCoffee,

no, I can't see it… good point! And anyway, I wonder whether background colors shouldn't be reworked altogether (including in the light theme, where IMHO, they could be a bit less prominent – sometimes, all is just yellow…), possibly adding an option to the View menu to make colors either more striking or more low-key.

Kind regards, Jörg-Michael

jmgrassau avatar Mar 25 '24 15:03 jmgrassau

Hi ConjuringCoffee,

I experimented a bit here, but it seems that while I can set the basic background color for each of these list items, the rest is done by the OS – both the blueish background when selecting the item, and the black background for the selected item when the focus is moved away. As of now, I didn't manage to override that. How to change SWT Table Item selection background color sounded promising, but I didn't get that running. Any Java / SWT wizards out there?

Kind regards, Jörg-Michael

jmgrassau avatar Jul 08 '24 10:07 jmgrassau