abap-cleaner icon indicating copy to clipboard operation
abap-cleaner copied to clipboard

Feature request: Access settings through "Preferences" menu of Eclipse

Open ConjuringCoffee opened this issue 1 year ago • 4 comments

As discussed in: https://github.com/SAP/abap-cleaner/issues/187#issuecomment-1803585165

Currently, the settings can only be accessed by starting a clean-up. I think it would be great if the ABAP Cleaner settings could be accessed through Eclipse's "Preferences" menu.

ConjuringCoffee avatar Nov 09 '23 12:11 ConjuringCoffee

Hi ConjuringCoffee,

I completely understand the idea, but I don't think it will be possible to move all the logic happening there into the "Preferences" menu, so unfortunately, out of scope. What might be considered is adding another menu like "Window / ABAP cleaner Preferences" below the central one, and whether that could take you directly to the configuration screen.

Starting a cleanup is not necessary since we have this nice third menu item:

image

This allows changing and saving configuration just like the interactive cleanup does.

Kind regards, Jörg-Michael

jmgrassau avatar Nov 09 '23 12:11 jmgrassau

Hi Jörg-Michael, would it be possible to have a link or a button to your custom settings within the "Preferences" menu? That would be sufficient to me.

For example, the debug settings open another window to configure project specific settings.

image

ConjuringCoffee avatar Nov 09 '23 13:11 ConjuringCoffee

Hey,

as a ABAP Cleaner - beginner I must confess that I searched first in Eclipse's preferences since there is the dedicated ABAP Development section there

CleanShot 2023-11-09 at 14 55 38

that also contains the Pretty Printer.

Regards, Vlad

VladGhitulescu avatar Nov 09 '23 13:11 VladGhitulescu

Would it be technical feasible to have the prefs as a view (see below the ABAP Favorites:

CleanShot 2023-11-09 at 14 59 45

?

VladGhitulescu avatar Nov 09 '23 14:11 VladGhitulescu