cloud-cap-samples-java icon indicating copy to clipboard operation
cloud-cap-samples-java copied to clipboard

Steps defined for Single Tenant deployment for Kyma doesn't work

Open robin-carry opened this issue 2 years ago • 4 comments

Currently if we follow the steps as defined in the README.md, on running the command cds add helm the generated values.yaml results in having sidecar (aka with respect to multi-tenant application) entry.

Without much deep understanding, did the following change to get it working:

  1. Removed the profile = with-mtx-sidecard
     "profiles": [
-        "with-mtx-sidecar",
         "java"
     ]
  1. Deleted the mtx folder (mtx/sidecar/package.json)

-- To follow the steps, deploy first in CF Trial landscape and then follow steps for single tenant and deploy in BTP Kyma Trial landscape.

robin-carry avatar Oct 25 '23 23:10 robin-carry

Thanks for raising that. But you followed the replacement instructions for the requires section in .cdsrc.json here: https://github.com/SAP-samples/cloud-cap-samples-java#add-deployment-files correct?

I think you are right, that this instruction misses to add the hint to remove the with-mtx-sidecar profile from the profiles section in .cdsrc.json.

EDIT: I just reproduced the issue and unfortunately it is really required to also delete the mtx folder as well. I think adopting the profiles is acceptable, but having to remove the folder I think is a bug/unfortunate behaviour of the cds add helm command.

@swaldmann what do you think?

beckermarc avatar Oct 26 '23 07:10 beckermarc

We currently assume a multitenant project if mtx/sidecar exists. Maybe we should loosen that a bit and only check for cds.requires.multitenacy → to be investigated internally in cap/cds-dk/pull/2256

swaldmann avatar Oct 26 '23 15:10 swaldmann

Thank you for confirming my assumption.

  1. Do you label Issue as defect or bug for showcasing accepted or filtering purpose?
  2. Where do I ask questions about these tutorials? I have other services like Kafka as resources in MTX app. I am not sure when I generate the helm chart how to go about the process of connectivity? Is there a script how the current tutorial help in creating service binding for SAP HANA Cloud? Or we can follow similar scripting for creating that?

robin-carry avatar Oct 26 '23 18:10 robin-carry

I added documentation and enhancement labels. Currently it works as designed, but we will revisit that and reiterate on that. Until that we can improve the documentation with the currently required steps already -> https://github.com/SAP-samples/cloud-cap-samples-java/pull/261

Where do I ask questions about these tutorials?

From CAP perspective you can check our documentation about this here: https://cap.cloud.sap/docs/resources/ Questions can be answered in the CAP space on answers.sap.com: https://answers.sap.com/tags/9f13aee1-834c-4105-8e43-ee442775e5ce. You can also ask Kyma deployment related questions there: https://answers.sap.com/tags/73554900100800003012

beckermarc avatar Oct 27 '23 07:10 beckermarc