docs icon indicating copy to clipboard operation
docs copied to clipboard

Update 'Handling "unit" calls' section

Open MangelMaxime opened this issue 6 years ago • 3 comments

On this page, there is a section dedicated to Handling "unit" calls.

Today, I released a new versions of Thoth.Json(.Net) which add support for unit. Could someone from the SAFE stack test it and see if it's working correctly?

If yes, then we should add a mention that since Thoth.Json 3.4.0 and Thoth.Json.Net 3.6.0 users can now use unit in their server response.

MangelMaxime avatar Oct 24 '19 12:10 MangelMaxime

Thanks @MangelMaxime - when https://github.com/SAFE-Stack/SAFE-template/pull/318 is ready I'll update the Thoth.Json dependencies to latest, test them and then when template ships with latest Thoth.Json we can add a note on that in docs :+1:

theimowski avatar Oct 25 '19 11:10 theimowski

@theimowski @MangelMaxime I think that we can close this, right?

isaacabraham avatar Sep 05 '20 14:09 isaacabraham

Hello @isaacabraham,

not yet the documentation still need an update because it says that unit is not supported by Thoth.Json while it is now.

MangelMaxime avatar Sep 05 '20 19:09 MangelMaxime

@isaacabraham I've removed that bit in this PR so I guess this can be closed once merged?

teknikal-wizard avatar Dec 09 '22 15:12 teknikal-wizard