SAFE-Nightwatch icon indicating copy to clipboard operation
SAFE-Nightwatch copied to clipboard

Unsure how to run as react-native-windows

Open majorgreys opened this issue 8 years ago • 4 comments

Given #9 and #10 I expected the demo to have the option to build using the react-native windows support, but it seems that package.json no longer contains the react-native-windows dependencies. What changes? What should be run to build it?

majorgreys avatar Jul 26 '17 04:07 majorgreys

It seems the relevant lines in package.json were removed by a latter commit ddd2c365e5b93c2ace19b89487c2417bc58b534f

majorgreys avatar Jul 26 '17 05:07 majorgreys

I had to remove because we had to upgrade react native and it didn't match versions. Maybe it's fine now. I'm open for pull requests

forki avatar Jul 26 '17 05:07 forki

This issue is referring to https://github.com/Microsoft/react-native-windows? Not sure that dependency needs to be in this demo app.

ctaggart avatar Mar 21 '18 17:03 ctaggart

Can be nuked.

Cameron Taggart [email protected] schrieb am Mi., 21. März 2018, 18:38:

This issue is referring to https://github.com/Microsoft/react-native-windows? Not sure that dependency needs to be in this demo app.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SAFE-Stack/SAFE-Nightwatch/issues/31#issuecomment-375032219, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNIqZqMuBhG63fytwyd-ZOiewzoDNks5tgpAcgaJpZM4Ojbli .

forki avatar Mar 21 '18 17:03 forki