S2Ler

Results 42 comments of S2Ler

Thank you @NathanaelA for feedback. I would be grateful if you can describe some of the issues you had in few words. It will help us to make the SDK...

@nick70007 what version of the SDK are you using?

This is probably due to https://github.com/mapbox/mapbox-navigation-ios/blob/19b637deac80f9240dd846e7ccb8b517e88e0fa5/MapboxCoreNavigation/NavigationRouteOptions.swift#L135-L136 I'm trying to find out the reason for this code.

@WilliamDenniss Please merge the PR.

This is for SDK similar to what Maps SDK team built. https://github.com/mapbox/mapbox-maps-ios/blob/main/scripts/api-compatibility-check/breaking-api-check.py

Tried this PR with the latest version and it doesn't fix stack overflow issue during deallocation phase.

Given that DirectionsPlayground(Former Example) app is separate project, we can bring back integration with Maps for better visualisation.

New example still not in a good shape. Editing query is buggy.

> Detected breaking changes are not related to current PR: > > ``` > 💔 API breakage: enumelement VisualInstruction.Component.guidanceView has declared type change from (MapboxDirections.VisualInstruction.Component.Type) -> (MapboxDirections.GuidanceViewImageRepresentation, MapboxDirections.VisualInstruction.Component.TextRepresentation) -> MapboxDirections.VisualInstruction.Component...